Skip to content

Comments

Feat/optional training start#1917

Open
Flix6x wants to merge 104 commits intomainfrom
feat/optional-training-start
Open

Feat/optional training start#1917
Flix6x wants to merge 104 commits intomainfrom
feat/optional-training-start

Conversation

@Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jan 14, 2026 •
edited by BelhsanHmida
Loading

Description

  • Stop relying on start-date to be set by the user
  • Stop relying on end-date to be set by the user
  • Start testing the ForecasterParametersSchema directly to validate derivation of timing parameters
  • Added changelog item in documentation/changelog.rst

Look & Feel

possible to run forecasting cli command without start_date or end_date:

Examples:

  • flexmeasures add forecasts --sensor 20 --start-date "2025-01-01T00:00:00+01"
  • flexmeasures add forecasts --sensor 20 --end-date "2025-01-15T00:00:00+01"
  • flexmeasures add forecasts --sensor 20

How to test

pytest flexmeasures/data/schemas/tests/test_forecasting.py

...

Further Improvements

  • Clarify train-period vs max-training-window in cli.data_add.train_predict_pipeline (and for our first example in forecasting.rst we should mention train-period rather than max-training-window).
  • Rename def train_predict_pipeline -> def add_forecast

Flix6x added 2 commits January 14, 2026 22:36
@Flix6x
feat: make start_date optional
53e65b2 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
docs: stop putting a focus on start-date
5dffa31 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.31.0 milestone Jan 14, 2026
@read-the-docs-community
Copy link

read-the-docs-community bot commented Jan 14, 2026 •
edited
Loading

Documentation build overview

📚 flexmeasures | 🛠️ Build #31434371 | 📁 Comparing bf7bf94 against latest (78fe15c)


🔍 Preview build

Show files changed (15 files in total): 📝 15 modified | ➕ 0 added | ➖ 0 deleted
File Status
changelog.html 📝 modified
genindex.html 📝 modified
_autosummary/flexmeasures.api.common.responses.html 📝 modified
_autosummary/flexmeasures.api.v3_0.sensors.html 📝 modified
_autosummary/flexmeasures.cli.utils.html 📝 modified
_autosummary/flexmeasures.data.models.data_sources.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.exceptions.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.pipelines.base.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.pipelines.train_predict.html 📝 modified
_autosummary/flexmeasures.data.schemas.forecasting.pipeline.html 📝 modified
_autosummary/flexmeasures.data.schemas.utils.html 📝 modified
_autosummary/flexmeasures.data.services.data_sources.html 📝 modified
api/v3_0.html 📝 modified
features/forecasting.html 📝 modified

@Flix6x Flix6x requested a review from BelhsanHmida January 15, 2026 08:49
Flix6x and others added 24 commits January 15, 2026 11:49
@Flix6x
feat: start testing timing parameters against ForecasterParametersSchema
0d98e4b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
dev: comment out failing test case
74f558e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
dev: fix commenting out failing test case
b33c4ba 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
fix: monkeypatch now
efa4d5b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
refactor: freeze server_now in every FlexMeasures module
1a88b4c 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
fix: failing tests (reproduced with `pytest -k "test_user_crud or tes…
5465fb6 
…t_timing_parameters_of_forecaster_parameters_schema"`)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@BelhsanHmida
feat: make end_date optional param
f9bbaae 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
feat: add optional end_date handling in ForecasterParametersSchema
d74d65e 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
dev: uncomment empty test case. with todo to include every timing par…
5866da8 
…ameter in expected_timing_output

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
style: run pre-commit
61811c8 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
docs: add changelog entry.
d5c77f1 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
Revert "docs: add changelog entry."
98a30e2 
This reverts commit d5c77f1.
@BelhsanHmida
chore: remove dev print statement
3bbbefb 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
feat: add not timing params giving test case
e7d46c7 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
test: only end_date given test_case
5f53b9a 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
test: add comments
ce33d4a 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
test: add case for both start and end dates in ForecasterParametersSc…
7077a42 
…hema

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
test: end_date and train_period test case
75e026d 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
test: add case for only start date with training period in Forecaster…
7c05dcc 
…ParametersSchema

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
test: add case for only start date with retrain frequency (predict_pe…
c286574 
…riod)

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
test: add case for start date with training period and retrain freque…
379470d 
…ncy (predict_period)

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
fix: correctly ensure start date is before end date in ForecasterPara…
bd606f7 
…metersSchema validation

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
style: run pre-commit
ed9d87a 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
chore: standardize timestamp floor method to lowercase '1h' because o…
ab18c13 
…f FutureWarning: 'H' is deprecated

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Flix6x and others added 30 commits February 14, 2026 21:00
@Flix6x
fix: update test input
427c175 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
refactor: move as-job out of the parameters schema
7e710d6 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: update test
bc2cc20 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: ensure backwards compatibility with DataGenerator subclasses who…
cfaa3ee 
…se _compute function do not support the as_job kwarg.

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: pass original instantiated fields instead of re-instantiating them
aa38852 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: prevent TrainPredictPipeline from catching exceptions and hiding…
05aba39 
… error messages

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: prevent empty forecast from being returned silently
04bfee8 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: set load_default for ensure-positive
5c2ddb8 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: parameters are already deserialized, so use **kwargs
6c6a561 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
refactor: move regressors to config
44f0fe3 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: load_default of regressor lists
64ff101 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
style: black
5f10f79 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
chore: update openapi-specs.json
4ff6c07 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: forecasting trigger schema
f7e5888 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: update test comments
1ac2f80 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
refactor: modify data rather than return new dict (this makes it easi…
5075d6f 
…er to add new fields)

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: move missing-threshold to config
7a29da0 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: move ensure-positive to config
089e2c2 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
delete: obsolete fields from parameters post_load
b4a9f39 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: check DataGenerator parameters explicitly
cda755f 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
style: flake8; remove obsolete imports
8b72aa4 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: prevent PredictPipeline from catching exceptions and hiding erro…
70da821 
…r messages

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: prevent TrainPipeline from catching exceptions and hiding error …
ee5a5a0 
…messages

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: expect the original ValueError instead of the CustomException
14dece5 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: prevent BasePipeline from catching exceptions and hiding error m…
f6bcaeb 
…essages

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: use an existing custom error that is more to the point
cf3c76f 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
remove: obsolete exception class and util
adad8d2 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: move over all config fields from CLI options to Forecaster config
f68826f 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@BelhsanHmida
Merge branch 'main' into feat/optional-training-start
54726c4
@BelhsanHmida
fix: suppress complexity warning for add_forecast function
bf7bf94 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BelhsanHmida BelhsanHmida Awaiting requested review from BelhsanHmida

At least 1 approving review is required to merge this pull request.

Assignees

@BelhsanHmida BelhsanHmida

Labels

Forecasting

Projects

None yet

Milestone

0.31.0

Development

Successfully merging this pull request may close these issues.

Make forecast training start optional

3 participants

@Flix6x @BelhsanHmida @nhoening