Skip to content

Comments

Update timing defaults in forecasting schema#1974

Draft
BelhsanHmida wants to merge 123 commits intofeat/optional-training-startfrom
dev/new-forecasting-defaults
Draft

Update timing defaults in forecasting schema#1974
BelhsanHmida wants to merge 123 commits intofeat/optional-training-startfrom
dev/new-forecasting-defaults

Conversation

@BelhsanHmida
Copy link
Contributor

@BelhsanHmida BelhsanHmida commented Feb 17, 2026 •
edited
Loading

Description

This PR updates values for forecasting timing parameters so that the expected test cases pass.

Timing defaults

  • predict-period → min(FM planning horizon, max-forecast-horizon)
  • max-forecast-horizon → predict-period
  • forecast-frequency → min(FM planning horizon, predict-period, max-forecast-horizon, retraining-frequency)
  • retraining-frequency → FM planning horizon

Constraint

  • max-forecast-horizon <= predict-period

Changes

  • Add timing defaults to forecasting schema
  • tests expects validation error
  • Ensure all forecasting tests pass

Sign-off

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@BelhsanHmida
feat: make predict retrain-frequency default to planning horizon then…
7d85db0 
… min(planning_horizon, data["max_forecast_horizon"])

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
refactor: simplify end_date calculation to use predict_period instead…
39e64ec 
… of timedelta

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
feat: default max_forecast_horizon to predict_period
9d83911 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
feat: add validation for max_forecast_horizon to ensure it does not e…
7543395 
…xceed predict_period

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
feat: set default forecast_frequency based on min of planning_horizon…
da4b943 
…, predict_period, and max_forecast_horizon

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
fix: add planning horizon from config
43d8d9d 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
dev: uncomment out tests that were failing
b3dd12d 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
fix: fix test cae forecast_frequency expectation it should be 12 hour…
24f1569 
…s not 48hours since we want New forecast viewpoint every 12 hours

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
fix: tests should expect 5 cycles. the test passes when we expect 1cycle
9c5d677 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@read-the-docs-community
Copy link

read-the-docs-community bot commented Feb 17, 2026 •
edited
Loading

Documentation build overview

📚 flexmeasures | 🛠️ Build #31498546 | 📁 Comparing de2256e against latest (d2d93ce)


🔍 Preview build

Show files changed (19 files in total): 📝 18 modified | ➕ 0 added | ➖ 1 deleted
File Status
changelog.html 📝 modified
genindex.html 📝 modified
index.html 📝 modified
_autosummary/flexmeasures.api.common.responses.html 📝 modified
_autosummary/flexmeasures.api.v3_0.sensors.html 📝 modified
_autosummary/flexmeasures.cli.utils.html 📝 modified
_autosummary/flexmeasures.data.models.data_sources.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.exceptions.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.pipelines.base.html 📝 modified
_autosummary/flexmeasures.data.models.forecasting.pipelines.train_predict.html 📝 modified
_autosummary/flexmeasures.data.schemas.forecasting.pipeline.html 📝 modified
_autosummary/flexmeasures.data.schemas.utils.html 📝 modified
_autosummary/flexmeasures.data.services.data_sources.html 📝 modified
api/v3_0.html 📝 modified
cli/change_log.html 📝 modified
concepts/commitments.html ➖ deleted
concepts/device_scheduler.html 📝 modified
features/forecasting.html 📝 modified

Flix6x and others added 20 commits February 17, 2026 10:52
@Flix6x
feat: add duration to schema
3642c9a 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: pass original data to resolve_config so we can check whether …
a448bf5 
…start, end and duration have been passed

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@BelhsanHmida
feat: move end_date calculation up
3456ffd 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
feat: fix max-forecast-horizon and forecast freq default calculation
a3c63a4 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@Flix6x
Merge remote-tracking branch 'origin/dev/new-forecasting-defaults' in…
acacac8 
…to dev/new-forecasting-defaults
@BelhsanHmida
dev: remove breakpoint
2c6e846 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@Flix6x
feat: throw ValidationError in case start, end and duration are all p…
b4d261c 
…assed

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/dev/new-forecasting-defaults' in…
cffe37e 
…to dev/new-forecasting-defaults
@BelhsanHmida
fix: remove unneeded validation
32e06af 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
style: run pre-commit
f3c31ab 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@Flix6x
refactor: move check to pre_load
2a805f0 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/dev/new-forecasting-defaults' in…
dda8485 
…to dev/new-forecasting-defaults
@BelhsanHmida
dev: comment out tests cases that pass
9e7acc9 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
fix: fix calculation for retrain_freq
6a5591c 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
Revert "dev: comment out tests cases that pass"
e4833df 
This reverts commit 9e7acc9.
@BelhsanHmida
style: run pre-commit
6db140d 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@BelhsanHmida
chore: regenerate openapi-spec.json
a2819ed 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@Flix6x
refactor: move parametrized cases next to case descriptions
930cf1c 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
dev: remove breakpoint
e8fab7e 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: check predict period
875ad1a 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Flix6x and others added 30 commits February 20, 2026 14:08
@Flix6x
fix: we are now guaranteed one cycle, and it is allowed to be smaller…
acfa1ba 
… than the retrain-frequency

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: counter in train_predict_params starts at 1
b82f0ef 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
dev: better error messages
8ac9666 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: update test case that tries to get two cycles out of the API
d0f0bf6 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: expose forecast-frequency to API users
048eb73 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
docs: update forecast-frequency default description
99b48e7 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@BelhsanHmida @Flix6x
docs: add comment
a2e69eb 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@BelhsanHmida @Flix6x
docs: add docstring
89f46c9 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
docs: update comment for selecting a default predict-period
a1b230f 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/dev/new-forecasting-defaults' in…
4bbe0bd 
…to dev/new-forecasting-defaults

# Conflicts:
#	flexmeasures/data/schemas/forecasting/pipeline.py
@Flix6x
fix: remove code after merge conflict
cab3c77 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
style: move flake8 noqa
f7dd443 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@BelhsanHmida
test(docs) update test comments
b682c0e 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@Flix6x
feat: move retrain-frequency to config
638517d 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
Merge remote-tracking branch 'refs/remotes/origin/dev/new-forecasting…
74cde4f 
…-defaults' into dev/new-forecasting-defaults
@BelhsanHmida
feat(test): uncomment and fix dates params
732469e 
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
@Flix6x
feat: ensure a retrain-frequency of at least 1 hour
b507d79 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: n_cycles now determined outside of schemas
b12f2df 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: update test coverage of ForecasterParametersSchema
ae24461 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
dev: partial fix for failing test
61329d1 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/dev/new-forecasting-defaults' in…
0d75075 
…to dev/new-forecasting-defaults
@Flix6x
fix: test_missing_data_logs_warning
027913a 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: test_train_period_capped_logs_warning
f7e8c75 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: test_trigger_and_fetch_forecasts
a689ad4 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: remove sensor from documented payload (it's in the URI path alre…
ff98cc3 
…ady)

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: move training timing fields from parameters to config
ea67caa 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
refactor: do not store any forecaster parameters by default
3eba171 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
refactor: move derivation of training period into class method, and a…
342d6e5 
…dd a docstring

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
refactor: simplify logic for deriving the training period
c3291ae 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
style: flake8
de2256e 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BelhsanHmida @Flix6x