Open
Conversation
valgrind shows memory as still reachable
in this test value is expected to be false, but should this return true?
now manual resource management anymore
this helped me figuring out that Catch itself includes <memory> and the tests compiled without including memory in CmdParser.hpp to compile this, type make sample now cmdparser.hpp is the first include in tests
FlorianRappl
requested changes
Oct 12, 2024
| REQUIRE(parser.has_help() == true); | ||
| REQUIRE(parser.app_name() == "myapp"); | ||
| REQUIRE(value == false); | ||
| REQUIRE(output.str().substr(0, prefix.size()) == prefix); |
Owner
There was a problem hiding this comment.
Sorry cannot accept PRs that break / change existing tests.
Contributor
Author
There was a problem hiding this comment.
Isn't that testcase never been reached beforehand anyway as exit() is called?
| #include <functional> | ||
|
|
||
| namespace cli { | ||
| /// Class used to wrap integer types to specify desired numerical base for specific argument parsing |
Owner
There was a problem hiding this comment.
This is too large / too much of a change. Sorry, won't be acceptable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the existing pull request on RAII, improved the resource alloction using shared ptr
Solved exit() problem with template based Policy