Fixed environment level CORS validation with right substring check #5335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wowmsi
reviewed
Oct 16, 2025
| callback(null, true) | ||
| } else { | ||
| callback(null, false) | ||
| const allowedOriginsList = allowedOrigins.split(',').map((o) => o.trim().toLowerCase()) |
There was a problem hiding this comment.
This can be pushed up for better readability and then the if condition can be rewritten asL
if (!origin || allowedOrigins == '*' || allowedOriginsList.includes(origin.toLowerCase())) {
callback(null, true)
} else {
callback(null, false)
}
Author
There was a problem hiding this comment.
allowedOriginsList.includes
I don't want to split "allowedOrigins" if it is just '*'. If it is not * then only it splits and compares with origin.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.