feat(ui): add accessible show/hide password toggle on signin#6098
feat(ui): add accessible show/hide password toggle on signin#6098sahil2448 wants to merge 1 commit intoFlowiseAI:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces management actions for Document Stores, enabling users to rename and delete stores from both card and table views. It also adds a password visibility toggle to the shared Input component and implements it on the sign-in page. The changes include permission-based access control for these new actions and local state management to prevent unnecessary UI flickering during updates. A review comment suggests improving the error message extraction logic to safely handle null response data.
fb9ceca to
5021a35
Compare
|
Thanks for the review and follow-up; i have now separated and cleaned both PRs by scope: the rename/delete feedback was fixed in the docstore PR (imports cleaned, useApi kept correctly, and delete flow updated to DeleteDocStoreDialog), and the signin PR now contains only the password visibility toggle changes, so both PRs are independent and clean—please review each PR against its respective issue. |
|
@sahil2448 Thanks for splitting it into two PRs. Approved. |
Related Issue
Fixes #6097
What this PR does
This PR adds a “View Password” toggle to the signin password field so users can reveal or hide their password while typing.
In simple terms, users can click or tap an eye icon to check what they typed, then hide it again before submitting.
Why this change
The password was always masked before, which made typo detection difficult, especially on mobile, with complex passwords, or for accessibility-related input needs.
This update reduces avoidable login failures and user frustration.
Scope of changes
Input.jsxsignIn.jsxBehavior implemented
type="password").type="text").Screen.Recording.2026-03-31.191558.mp4
Accessibility
aria-labelfor screen readers.Regression risk
Low.
The new behavior is opt-in via
enablePasswordToggle, and only signin currently enables it.No backend, API, or auth logic was changed.