Feat/docstore rename delete actions (optimised for dark theme)#6144
Open
sahil2448 wants to merge 1 commit intoFlowiseAI:mainfrom
Open
Feat/docstore rename delete actions (optimised for dark theme)#6144sahil2448 wants to merge 1 commit intoFlowiseAI:mainfrom
sahil2448 wants to merge 1 commit intoFlowiseAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces management actions for document stores, including rename and delete capabilities in both card and table views. It adds action menus, permission-based access control, and local state management to improve the user experience during store modifications. Feedback provided suggests using unique IDs for React keys, consolidating duplicated styles for action buttons, and refactoring error message parsing for better maintainability.
061c7f9 to
ac05e2c
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimized docstore's rename/delete feature for dark theme
fix(ui): improve dark theme contrast for docstore action menu button
Summary
This PR addresses reviewer feedback about the 3-dot action button (rename/delete menu) not being visually clear in dark theme.
What I changed
IconButtonstyling in both docstore views:Why this change
In dark mode, the old button colors had low contrast. This update improves visibility while keeping the same behavior and UI flow.
Scope
Verification