refactor nav as function component#136
Open
CrystalSplitter wants to merge 6 commits intoFluentFlame:masterfrom
Open
refactor nav as function component#136CrystalSplitter wants to merge 6 commits intoFluentFlame:masterfrom
CrystalSplitter wants to merge 6 commits intoFluentFlame:masterfrom
Conversation
- Convert Menu class component to functional component using useAppSelector/useAppDispatch - Inline Redux connect() logic from menu-container.tsx - Replace <a> tags with <button> tags for .btn elements - Add button reset styles to global.css for .btn class - Add ARIA labels and roles for accessibility - Delete menu-container.tsx
- Convert Page class component to functional component using useAppSelector/useAppDispatch - Inline Redux connect() logic from page-container.tsx - Replace <a> tags with <button> tags for .btn elements - Add alt attributes to logo images, aria-labels to nav buttons - Fix negated ternary condition and leaked value warnings - Delete page-container.tsx
- Convert Settings class component to functional component using useAppSelector/useAppDispatch - Inline Redux connect() logic from settings-container.tsx - Convert componentDidUpdate lifecycle to useEffect with display dependency - Use useRef for exitting to avoid stale closure in keydown handler - Replace <a> tag with <button> tag for back button - Add aria-label and disabled attribute for accessibility - Fix nested if-in-else structure - Delete settings-container.tsx
Collaborator
|
Tbh I'm not sure about merging upstream because the code's been messed with by AI, which goes against our contribution guidelines, so I think we really need to check that everything is safe, correct, and actually works, and maybe even rewrite or fix stuff if we have to. |
Collaborator
Author
|
Yeah, I'm seeing that now. I do think it would be nice to get rid of the container components, as I think they are a design anti-pattern, but it's not urgent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back-merge from fluent-reader
Ideally, we should always be ahead of fluent-reader and integrate the changes
in case we ever do get the chance to port our fixes over.