Re-organise "built-in layers" section #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Once the build has completed, you can preview any updated documentation at this URL: https://fluxml.ai/Flux.jl/previews/PR2112/ in ~20 minutes Thanks robot. Humans, see especially https://fluxml.ai/Flux.jl/previews/PR2112/models/layers/ , and compare to: http://fluxml.ai/Flux.jl/dev/models/layers/ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
This should be ready, and does not seem likely to be controversial. |
Saransh-cpp
approved these changes
Nov 30, 2022
Member
Saransh-cpp
left a comment
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks, @mcabbott! Looks good to me!
Saransh-cpp
reviewed
Nov 30, 2022
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While moving things around in #2069, I didn't like the "other general purpose" heading in layers.md... so this tried to put them into some less-random arrangement?
Edit:
less finished than I thought it was... hence draft for now.Still written as if #1932 were merged.Now all mention of@layerremoved.Also adds a warning about #2122 pending something better.