Add addition and substraction of xs:dayTimeDuration() #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (2)
Total files change +693B +0.43% Final result: ✅ View report in BundleMon website ➡️ |
DrRataplan
approved these changes
Aug 5, 2025
Contributor
|
Hey @aheissenberger, Thanks so much! This looks awesome! @bwrrp do you have some bandwidth to check this out? Assuming CI is green I'm 100% OK with the approach taken! |
bwrrp
reviewed
Sep 1, 2025
| } | ||
|
|
||
| public negate(): this { | ||
| return new (this.constructor as any)(-this.seconds); |
Member
There was a problem hiding this comment.
This assumes any subclass uses the same argument for its constructor - why not use the class itself directly?
bwrrp
approved these changes
Sep 1, 2025
Member
bwrrp
left a comment
bwrrp
left a comment
There was a problem hiding this comment.
Awesome contribution, thank you so much! I've left a minor comment on the use of constructors in the negate methods, but this looks good to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request fixes the missing possibility to add and subtract DateTimeDuration.
xs:dateTime("1970-01-01T00:00:00Z") + xs:dayTimeDuration("P15DT11H59M59S")