Conversation
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
Ilaiwi
commented
Jan 22, 2019
Author
There was a problem hiding this comment.
for dateHeader the following is missing
intervalRenderertestsunittests should cover more general cases with different timeline units
for custom headers the following- test calculating left and width in intervals (let us talk about this)
unittests should cover more general cases with different timeline units
please also check tests where we pass extra props to CustomHeader, DateHeader and SidebarHeader
for unit prop tests it should only be in custom headers and in date header just test props related to primary and secondary transformations
|
|
||
|
|
||
| it("Given Dateheader When click on the primary header Then it should change the format", async () => { | ||
|
|
Author
There was a problem hiding this comment.
please test this though onTimeChange
| const seconderyHeader = getAllByTestId('dateHeader')[2] | ||
| const unitHeader = getAllByTestId('dateHeader')[1] | ||
|
|
||
| const unitHeaderChildrenBeforeClick = unitHeader.childElementCount |
Author
There was a problem hiding this comment.
I think this is very tied to the implementation. Lets talk about this later
|
|
||
| }) | ||
|
|
||
| it("Given Dateheader When click on the secondary header Then it should change the format", async () => { |
…tions/react-calendar-timeline into custom-headers-test
…tions/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
…/react-calendar-timeline into custom-headers-test
**Issue Number** namespace-ee#349 **Overview of PR** this PR adds the following features: 1. render more headers in the header section 2. add the ability to add completely customized headers. To checkout, the work run the demo and chose `customHeaders` demo  _**This work is still really really early and only to show core concept of the feature and to show progress**_ ### TODO - [x] fix drag items bug where extra custom headers cause items to not be correctly positioned correctly dragging - [x] convert to propGetter pattern - [x] add style and classnames props to customize headers root element - [x] add props to style root element and add classnames to root element - [x] add render prop for `DateHeader` for intervals - [x] fix broken tests - [x] add documentation - [x] add tests for custom headers - [x] delete format props - [x] refactor and test - [x] decide what to do with sticky header prop - [x] handle `headerRef` prop - [x] maybe unify `CustomHeader` and `VerticalLines` label width calculation - [x] make sure plugins don't break - [x] delete sidebarContent and rightSidebarContent readme - [x] delete `headerLabelGroupHeight` and `headerLabelHeight` - [x] delete header css classes - [x] custom header/day header pass primary/secondary via unit - [x] pass components and functions for render prop - [x] remove format object option from labelFormat - [x] default styles in DateHeader => move to classnames and don't provide them if provide interval renderer - [x] fix custom header docs (interval) - [x] must pass height to custom headers? how do we fix this? - [x] check if programmatically scrolling example work - [x] write breaking change docs - [x] cleanup old code - [ ] handle touch state in `TimelineElementsHeader` - [ ] fix a bug, where headers interval borders are not aligned with the vertical lines, form the calendar - [ ] add an option to deal with `unit` as an interval of time - [ ] pass `unit` as interval iterateTimes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
Link to issue this PR addresses. If no issue exists, please provide reasoning for PR.
Overview of PR
Provide an overview of the changes in this PR.
Don't forget to update the CHANGELOG.md file with any changes that are in this PR