Release PR #345
Release PR #345
Conversation
|
View your CI Pipeline Execution ↗ for commit 5832072
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (18.79%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 18.52% 18.79% +0.26%
==========================================
Files 138 140 +2
Lines 27402 27640 +238
Branches 963 980 +17
==========================================
+ Hits 5076 5194 +118
- Misses 22326 22446 +120 🚀 New features to boost your workflow:
|
|
Deployed 0603f1f to https://ForgeRock.github.io/ping-javascript-sdk/pr-345/0603f1febc8de0b5bd6d1e6415ba4fd2aa6b08b7 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-82.4 KB, -100.0%) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
changeset-release/main
branch
7 times, most recently
from
7f85e3d to
84aa034
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
6 times, most recently
from
d5812af to
997d98a
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
4 times, most recently
from
5eb620d to
954ce37
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
5 times, most recently
from
a5a72fb to
fae494a
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
1fceeb2 to
022b06c
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
022b06c to
625b514
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
807f1bc to
28207cd
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
packages/sdk-effects/oidc/CHANGELOG.md (1)
14-14: Fix the stray hyphen in the changelog entry (duplicate of past review).Line 14 displays "- - Adds tests for OIDC effects package" with an extra leading hyphen. A previous review already flagged this issue; it remains unresolved.
Remove the extra hyphen so the bullet renders as a single list item.
-- [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - - Adds tests for OIDC effects package +- [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - Adds tests for OIDC effects packagepackages/oidc-client/CHANGELOG.md (1)
22-23: Fix the stray hyphen in the changelog entry (duplicate of past review).Lines 22–23 display "- - Standardizes return types on storage client and updates tests" with an extra leading hyphen. A previous review already flagged this issue; it remains unresolved.
Remove the extra hyphen so the bullet renders as a single list item.
-- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests +- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (44)
.changeset/breezy-actors-sell.md(0 hunks).changeset/bright-lights-yawn.md(0 hunks).changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/good-games-accept.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/kind-guests-sneeze.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/orange-peaches-warn.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/slow-teeth-melt.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/tender-schools-scream.md(0 hunks).changeset/thin-nights-send.md(0 hunks).changeset/tired-melons-wish.md(0 hunks).changeset/wild-items-stop.md(0 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/journey-client/CHANGELOG.md(1 hunks)packages/journey-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (22)
- .changeset/small-rats-cut.md
- .changeset/fine-windows-search.md
- .changeset/dull-rockets-give.md
- .changeset/wild-items-stop.md
- .changeset/bright-lights-yawn.md
- .changeset/public-cougars-sneeze.md
- .changeset/moody-chefs-hammer.md
- .changeset/kind-guests-sneeze.md
- .changeset/shiny-crabs-wish.md
- .changeset/calm-waves-change.md
- .changeset/tender-schools-scream.md
- .changeset/spotty-tires-admire.md
- .changeset/icy-olives-make.md
- .changeset/dirty-queens-design.md
- .changeset/slow-teeth-melt.md
- .changeset/every-bottles-sleep.md
- .changeset/good-games-accept.md
- .changeset/breezy-actors-sell.md
- .changeset/tired-melons-wish.md
- .changeset/chubby-chairs-dream.md
- .changeset/orange-peaches-warn.md
- .changeset/thin-nights-send.md
✅ Files skipped from review due to trivial changes (2)
- packages/sdk-effects/logger/package.json
- packages/davinci-client/package.json
🚧 Files skipped from review as they are similar to previous changes (15)
- packages/sdk-effects/oidc/package.json
- packages/sdk-utilities/package.json
- packages/sdk-effects/storage/package.json
- packages/protect/CHANGELOG.md
- packages/journey-client/package.json
- packages/sdk-effects/iframe-manager/package.json
- packages/sdk-types/CHANGELOG.md
- packages/sdk-types/package.json
- packages/sdk-effects/iframe-manager/CHANGELOG.md
- packages/oidc-client/package.json
- packages/journey-client/CHANGELOG.md
- packages/sdk-effects/sdk-request-middleware/package.json
- packages/davinci-client/CHANGELOG.md
- packages/sdk-utilities/CHANGELOG.md
- packages/sdk-effects/logger/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (1)
packages/protect/package.json (1)
3-3: Version bump aligns with release PR objectives.The version bump to 1.3.0 is consistent with the Changesets release automation and the PR's goal to release the newly implemented Ping Protect package.
|
|
||
| - [#348](https://github.com/ForgeRock/ping-javascript-sdk/pull/348) [`beb349a`](https://github.com/ForgeRock/ping-javascript-sdk/commit/beb349a9a13e7bb8fbad35bf9bda9e340545cffa) Thanks [@cerebrl](https://github.com/cerebrl)! - Implemented token exchange within OIDC Client | ||
|
|
||
| - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests |
There was a problem hiding this comment.
Fix the stray hyphen in the changelog entry.
Line 13 displays "- - Standardizes return types on storage client and updates tests" with an extra leading hyphen, creating a double-bullet rendering issue. This same formatting defect appears in the corresponding entry in oidc-client/CHANGELOG.md.
Remove the extra hyphen so the bullet renders cleanly.
-- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests
+- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests | |
| - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests |
🤖 Prompt for AI Agents
In packages/sdk-effects/storage/CHANGELOG.md around line 13, the changelog entry
contains a stray extra hyphen ("- - Standardizes...") causing a double-bullet;
remove the leading extra hyphen so the line reads a single hyphen followed by
the text ("- Standardizes return types on storage client and updates tests");
also apply the same correction to the matching entry in oidc-client/CHANGELOG.md
to keep both changelogs consistent.
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
1de5458 to
fb05d62
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
2 times, most recently
from
e5eecb7 to
09f443e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
from
09f443e to
1b7cb55
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
packages/oidc-client/CHANGELOG.md (1)
22-23: Fix the stray hyphen in the changelog entry.Line 22 has a double hyphen ("- - Standardizes") that will render with an extra bullet in published notes. Remove the extra hyphen so it renders as a single bullet.
- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests + [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests
🧹 Nitpick comments (1)
packages/protect/CHANGELOG.md (1)
7-7: Fix capitalization of "Ping Protect" in changelog entry description.The product name should be consistently capitalized as "Ping Protect" to match the PR objectives and other package changelogs in this release.
Apply this diff to fix the capitalization:
-- Implemented ping protect package +- Implemented Ping Protect package
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (49)
.changeset/breezy-actors-sell.md(0 hunks).changeset/bright-lights-yawn.md(0 hunks).changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/good-games-accept.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/kind-guests-sneeze.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/orange-peaches-warn.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/slow-teeth-melt.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/tender-schools-scream.md(0 hunks).changeset/thin-nights-send.md(0 hunks).changeset/tired-melons-wish.md(0 hunks).changeset/vast-dogs-make.md(0 hunks).changeset/wild-items-stop.md(0 hunks)e2e/journey-app/CHANGELOG.md(1 hunks)e2e/journey-app/package.json(1 hunks)e2e/journey-suites/CHANGELOG.md(1 hunks)e2e/journey-suites/package.json(1 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/journey-client/CHANGELOG.md(1 hunks)packages/journey-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (23)
- .changeset/spotty-tires-admire.md
- .changeset/dull-rockets-give.md
- .changeset/moody-chefs-hammer.md
- .changeset/slow-teeth-melt.md
- .changeset/vast-dogs-make.md
- .changeset/calm-waves-change.md
- .changeset/tender-schools-scream.md
- .changeset/kind-guests-sneeze.md
- .changeset/tired-melons-wish.md
- .changeset/small-rats-cut.md
- .changeset/icy-olives-make.md
- .changeset/wild-items-stop.md
- .changeset/orange-peaches-warn.md
- .changeset/dirty-queens-design.md
- .changeset/shiny-crabs-wish.md
- .changeset/good-games-accept.md
- .changeset/every-bottles-sleep.md
- .changeset/bright-lights-yawn.md
- .changeset/fine-windows-search.md
- .changeset/thin-nights-send.md
- .changeset/breezy-actors-sell.md
- .changeset/public-cougars-sneeze.md
- .changeset/chubby-chairs-dream.md
✅ Files skipped from review due to trivial changes (2)
- packages/sdk-effects/sdk-request-middleware/CHANGELOG.md
- e2e/journey-suites/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (17)
- packages/oidc-client/package.json
- packages/sdk-types/package.json
- packages/sdk-effects/iframe-manager/package.json
- packages/journey-client/CHANGELOG.md
- packages/sdk-utilities/CHANGELOG.md
- packages/journey-client/package.json
- packages/davinci-client/package.json
- packages/sdk-types/CHANGELOG.md
- packages/sdk-effects/logger/CHANGELOG.md
- packages/sdk-effects/logger/package.json
- packages/sdk-effects/oidc/CHANGELOG.md
- packages/protect/package.json
- packages/sdk-effects/iframe-manager/CHANGELOG.md
- e2e/journey-app/CHANGELOG.md
- packages/sdk-effects/storage/CHANGELOG.md
- packages/davinci-client/CHANGELOG.md
- e2e/journey-suites/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (6)
packages/oidc-client/CHANGELOG.md (1)
3-40: Changelog structure and consistency look good.The 1.3.0 release section is well-structured with appropriate categorization of changes into Minor and Patch sections, proper linking to PRs and commits, and accurate attribution. Dependency updates are correctly versioned to 1.3.0 across all related packages.
e2e/journey-app/package.json (1)
3-3: Version alignment is consistent with the release.The version bump to 1.3.0 aligns with the broader package versioning in this release PR. Since all workspace dependencies reference
workspace:*, they will correctly resolve to the new versions.packages/sdk-effects/storage/package.json (1)
3-3: Version bump to 1.3.0 looks good.The version bump is appropriate for this coordinated minor release, and workspace dependencies remain correctly configured for Changesets-managed publishing.
packages/sdk-effects/oidc/package.json (1)
3-3: Version bump to 1.3.0 is consistent with the coordinated release.Workspace dependencies (@forgerock/sdk-types, @forgerock/sdk-utilities) remain properly configured for Changesets publishing.
packages/sdk-utilities/package.json (1)
3-3: Version bump to 1.3.0 approved.The public API surface (exports for constants, types, and default entry point) remains unchanged. The version bump is appropriate for this minor release.
packages/sdk-effects/sdk-request-middleware/package.json (1)
3-3: Version bump to 1.3.0 is appropriate.The cataloged dependency (@reduxjs/toolkit) is correctly preserved without modification. This aligns with the coordinated 1.3.0 release across the SDK packages.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
6 times, most recently
from
972c198 to
1109650
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
from
1109650 to
c63f344
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
packages/sdk-types/CHANGELOG.md (1)
11-13: Fix categorization: Move OIDC logout/userinfo entry to Minor Changes.The entry for "Implement OIDC logout and user info request" on line 13 is a new feature addition and should be categorized under Minor Changes, not Patch Changes.
Apply this diff to correct the categorization:
### Minor Changes - [#412](https://github.com/ForgeRock/ping-javascript-sdk/pull/412) [`b0f4368`](https://github.com/ForgeRock/ping-javascript-sdk/commit/b0f4368637a788c5472587f5232678312a7eabfe) Thanks [@ryanbas21](https://github.com/ryanbas21)! - feat: Update SDK types - Updated ESLint configurations for consistent code style and linting rules. - Ensured compatibility with `verbatimModuleSyntax` by correcting type-only imports and module exports. + + - [#363](https://github.com/ForgeRock/ping-javascript-sdk/pull/363) [`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement OIDC logout and user info request; includes type updates and global error type ### Patch Changes - - - [#363](https://github.com/ForgeRock/ping-javascript-sdk/pull/363) [`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement OIDC logout and user info request; includes type updates and global error typepackages/oidc-client/CHANGELOG.md (1)
22-23: Remove stray hyphen in changelog entry.Line 22 has a double-hyphen bullet ("- -") that should be a single hyphen.
Apply this diff:
- - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests + - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates testspackages/sdk-effects/oidc/CHANGELOG.md (1)
14-15: Remove stray hyphen in changelog entry.Line 14 has a double-hyphen bullet ("- -") that should be a single hyphen.
Apply this diff:
- - [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - - Adds tests for OIDC effects package + - [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - Adds tests for OIDC effects package
🧹 Nitpick comments (1)
packages/sdk-effects/logger/CHANGELOG.md (1)
3-9: Changelog entry format is consistent; minor formatting note on commit-message prefix.The new 1.3.0 section is well-structured and accurately documents the ESLint and verbatimModuleSyntax changes mentioned in the PR objectives. The changelog entry aligns with the overall release scope. Note that the commit-message prefix "feat: Update SDK logger" (line 7) differs slightly from the 1.2.0 entry format (line 15), which omits such a prefix. Consider aligning the style across entries for consistency, though this is a minor aesthetic detail.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (49)
.changeset/breezy-actors-sell.md(0 hunks).changeset/bright-lights-yawn.md(0 hunks).changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/good-games-accept.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/kind-guests-sneeze.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/orange-peaches-warn.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/slow-teeth-melt.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/tender-schools-scream.md(0 hunks).changeset/thin-nights-send.md(0 hunks).changeset/tired-melons-wish.md(0 hunks).changeset/vast-dogs-make.md(0 hunks).changeset/wild-items-stop.md(0 hunks)e2e/journey-app/CHANGELOG.md(1 hunks)e2e/journey-app/package.json(1 hunks)e2e/journey-suites/CHANGELOG.md(1 hunks)e2e/journey-suites/package.json(1 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/journey-client/CHANGELOG.md(1 hunks)packages/journey-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (23)
- .changeset/dull-rockets-give.md
- .changeset/every-bottles-sleep.md
- .changeset/icy-olives-make.md
- .changeset/small-rats-cut.md
- .changeset/tired-melons-wish.md
- .changeset/moody-chefs-hammer.md
- .changeset/breezy-actors-sell.md
- .changeset/chubby-chairs-dream.md
- .changeset/thin-nights-send.md
- .changeset/bright-lights-yawn.md
- .changeset/orange-peaches-warn.md
- .changeset/kind-guests-sneeze.md
- .changeset/slow-teeth-melt.md
- .changeset/public-cougars-sneeze.md
- .changeset/shiny-crabs-wish.md
- .changeset/spotty-tires-admire.md
- .changeset/wild-items-stop.md
- .changeset/tender-schools-scream.md
- .changeset/fine-windows-search.md
- .changeset/dirty-queens-design.md
- .changeset/good-games-accept.md
- .changeset/vast-dogs-make.md
- .changeset/calm-waves-change.md
✅ Files skipped from review due to trivial changes (3)
- packages/sdk-effects/sdk-request-middleware/package.json
- packages/sdk-effects/storage/CHANGELOG.md
- packages/sdk-effects/sdk-request-middleware/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (13)
- e2e/journey-suites/CHANGELOG.md
- packages/protect/CHANGELOG.md
- packages/sdk-utilities/CHANGELOG.md
- packages/sdk-types/package.json
- packages/sdk-effects/oidc/package.json
- packages/journey-client/CHANGELOG.md
- packages/davinci-client/package.json
- packages/sdk-effects/iframe-manager/package.json
- packages/sdk-effects/logger/package.json
- packages/oidc-client/package.json
- e2e/journey-app/package.json
- e2e/journey-app/CHANGELOG.md
- packages/sdk-effects/storage/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-23T20:50:26.537Z
Learnt from: ancheetah
Repo: ForgeRock/ping-javascript-sdk PR: 417
File: packages/sdk-effects/storage/src/lib/storage.effects.ts:11-12
Timestamp: 2025-09-23T20:50:26.537Z
Learning: When the storage client API was changed from returning void to GenericError | null in SDKS-4361, call sites in DaVinci client and OIDC client were not updated to handle the returned errors, creating a follow-up task for proper error handling implementation.
Applied to files:
packages/davinci-client/CHANGELOG.md
📚 Learning: 2025-10-22T15:14:00.044Z
Learnt from: ryanbas21
Repo: ForgeRock/ping-javascript-sdk PR: 430
File: packages/journey-client/src/lib/callbacks/name-callback.ts:9-15
Timestamp: 2025-10-22T15:14:00.044Z
Learning: In packages/journey-client, callback classes are internal implementation details not part of the public API. The callbacks barrel (src/lib/callbacks/index.ts) intentionally only exports the base JourneyCallback class. Internal code imports concrete callback classes directly from their individual files (e.g., factory.ts, journey-client.ts).
Applied to files:
packages/journey-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (7)
packages/sdk-utilities/package.json (1)
3-3: Version bump is correct.The version update to 1.3.0 aligns with the coordinated release across the package set, as indicated by the PR objectives.
e2e/journey-suites/package.json (1)
3-3: Version bump aligns with coordinated release.The version is appropriately bumped to 1.3.0 as part of the monorepo's coordinated release. Since this package is marked as private, the version serves for internal consistency across the e2e test suites.
packages/journey-client/package.json (1)
3-3: Version bump to 1.3.0 aligns with release objectives.The version bump is consistent with the coordinated 1.3.0 release across multiple packages. Package metadata, exports, dependencies, and build configuration remain properly configured.
packages/protect/package.json (2)
3-3: Version bump aligns with coordinated 1.3.0 release.The version is correctly bumped to 1.3.0 as part of the PR's coordinated release across all packages, and matches the corresponding changelog entry noting the Ping Protect package implementation.
28-28: Verify that empty dependencies is intentional.The package currently has no dependencies declared. Confirm this is appropriate for the Ping Protect package's scope and functionality.
packages/davinci-client/CHANGELOG.md (1)
3-27: Changelog structure looks good.No formatting or categorization issues detected in this file's 1.3.0 release notes.
packages/sdk-effects/iframe-manager/CHANGELOG.md (1)
7-16: Entries for PR #348 and #344 correctly belong in iframe-manager's CHANGELOG.Both commits modified
packages/sdk-effects/iframe-manager/src/lib/iframe-manager.effects.ts. PR #344 exported theResolvedParamstype and converted the default export to a named export; PR #348 fixed a bug in error-handling logic. These are legitimate iframe-manager changes that support the OIDC Client integration, not accidental inclusions.The changelog descriptions accurately reflect the features these PRs implemented, though they emphasize the OIDC Client context. No changes needed.
Likely an incorrect or invalid review comment.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
2 times, most recently
from
6769ee2 to
409b403
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
409b403 to
4b55057
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
4b55057 to
5832072
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@forgerock/davinci-client@1.3.0
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#340
0fa522aThanks @ancheetah! - Implemented Ping Protect collector#396
036f495Thanks @ancheetah! - Added support for pre-filled phone number and country code#468
fd14ca9Thanks @ancheetah! - Adds FIDO feature module to@forgerock/davinci-clientpackage#428
b327c79Thanks @ancheetah! - Added WebAuthn/FIDO2 collectorsPatch Changes
#413
9213bb9Thanks @ancheetah! - ExposesrequiredandvalidatePhoneNumberproperties on collectors#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error typeUpdated dependencies [
b0f4368,beb349a,dc4d4bd,7ffa428,6c06e70,93595d2,fd14ca9,b0f4368,ef4ab6f,b0f4368]:@forgerock/oidc-client@1.3.0
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#376
c48d9c8Thanks @ancheetah! - Implement tokenrevokemethod#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#402
bdbbbd2Thanks @cerebrl! - Implement force renew and revoke tokens that are replaced to tokens.get method#368
5fe1f95Thanks @ancheetah! - Added tests for oidc client#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error type#417
93595d2Thanks @ancheetah! - - Standardizes return types on storage client and updates tests#378
4d0ee71Thanks @cerebrl! - Migrate /authorize to RTK Query and improve result types#369
7cb0519Thanks @cerebrl! - Implement tokengetmethod for local tokens and autorenewPatch Changes
#471
ef4ab6fThanks @ancheetah! - Append query params to authorization url when providedUpdated dependencies [
b0f4368,beb349a,dc4d4bd,b0f4368,7ffa428,6c06e70,93595d2,fd14ca9,b0f4368,ef4ab6f,b0f4368]:@forgerock/protect@1.3.0
Minor Changes
18677d9Thanks @ancheetah! - Implemented ping protect package@forgerock/iframe-manager@1.3.0
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#412
b0f4368Thanks @ryanbas21! - feat: Update iframe-managerverbatimModuleSyntaxby correcting type-only imports and module exports.@forgerock/sdk-logger@1.3.0
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK loggerverbatimModuleSyntaxby correcting type-only imports and module exports.@forgerock/sdk-oidc@1.3.0
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#416
7ffa428Thanks @ancheetah! - - Adds tests for OIDC effects packagegetStorageKeyutilityPatch Changes
#471
ef4ab6fThanks @ancheetah! - Append query params to authorization url when providedUpdated dependencies [
b0f4368,6c06e70,fd14ca9,b0f4368]:@forgerock/storage@1.3.0
Minor Changes
#412
b0f4368Thanks @ryanbas21! - feat: Update storage packageverbatimModuleSyntaxby correcting type-only imports and module exports.#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#417
93595d2Thanks @ancheetah! - - Standardizes return types on storage client and updates testsPatch Changes
#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error typeUpdated dependencies [
6c06e70,fd14ca9,b0f4368]:@forgerock/sdk-types@1.3.0
Minor Changes
#468
fd14ca9Thanks @ancheetah! - Adds FIDO feature module to@forgerock/davinci-clientpackage#412
b0f4368Thanks @ryanbas21! - feat: Update SDK typesverbatimModuleSyntaxby correcting type-only imports and module exports.Patch Changes
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error type@forgerock/sdk-utilities@1.3.0
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK utilitiesREQUESTED_WITHandX_REQUESTED_PLATFORMconstants with literal types for better tree-shaking and type narrowing.@forgerock/sdk-request-middleware@1.3.0
@forgerock/journey-client@1.3.0
Minor Changes
#412
b0f4368Thanks @ryanbas21! - feat: Implement new journey clientjourney()factory function for creating stateful client instances.resumelogic to correctly persist and retrieve plainSteppayloads, resolving prototype loss issues during serialization.#412
b0f4368Thanks @ryanbas21! - feat(journey-client): Add WebAuthn, QR Code, and Recovery Code supportFRWebAuthn,FRQRCode,FRRecoveryCodes) to handle advanced authentication methods within authentication journeys.TextOutputCallbackwas being incorrectly inferred asTextInputCallback.Patch Changes
b0f4368,b0f4368,beb349a,6c06e70,93595d2,fd14ca9,b0f4368,b0f4368]:@forgerock/journey-app@1.3.0
Patch Changes
beb349a,c48d9c8,dc4d4bd,bdbbbd2,b0f4368,5fe1f95,b0f4368,6c06e70,93595d2,4d0ee71,7cb0519,ef4ab6f,b0f4368]:@forgerock/journey-suites@1.3.0
Summary by CodeRabbit
New Features
Improvements