add safety check on scroll method #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Scroller is destroyed right after starting to animate the scroll position, it throws an exception. (TypeError: 'undefined' is not an object (evaluating 'data.horizontal') on line 95) Catch if the data attribute is already gone and don’t try to do anything if that’s the case. Tested and confirmed this will prevent the error. The diff looks really strange because of a block indent, but the only thing actually modified is scroller.js line 73.
Contributor
Author
|
@benplum Can you take a look at this when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Scroller is destroyed right after starting to animate the scroll position, it throws an exception. (TypeError: 'undefined' is not an object (evaluating 'data.horizontal') on line 95) Catch if the data attribute is already gone and don’t try to do anything if that’s the case. Tested and confirmed this will prevent the error.
The diff looks really strange because of a block indent, but the only thing actually modified is scroller.js line 73.