Skip to content

Make VariantBean.gender optional and remove provisional enum value #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Make VariantBean.gender optional and remove provisional enum value #40

wants to merge 2 commits into from
+15 −8

Conversation

@Luc1412
Copy link
Member

@Luc1412 Luc1412 commented Dec 22, 2024

Summary

This PR makes VariantBean.gender optional and removes the provisional enum value CustomGender.UNKNOWN introduced in 3.2.1.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Luc1412
Make VariantBean.gender optional
93137b2 
Remove CustomGender.UNKNOWN
@Luc1412 Luc1412 added the breaking change This issue requires a breaking change. label Dec 22, 2024
@Luc1412 Luc1412 self-assigned this Dec 22, 2024
@Luc1412 Luc1412 marked this pull request as draft September 25, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trevorflahardy trevorflahardy Awaiting requested review from trevorflahardy

At least 1 approving review is required to merge this pull request.

Assignees

@Luc1412 Luc1412

Labels

breaking change This issue requires a breaking change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Luc1412