Skip to content

fix: fix broken test workflow (issue 77)#79

Open
laurigates wants to merge 1 commit intomasterfrom
claude/issue-77-20260320-2010
Open

fix: fix broken test workflow (issue 77)#79
laurigates wants to merge 1 commit intomasterfrom
claude/issue-77-20260320-2010

Conversation

@laurigates
Copy link
Member

Fix 100% failure rate in test workflow.

Changes

  • .pre-commit-config.yaml: Change biome-format hook from language: system + npx to language: node + additional_dependencies. Pre-commit now manages biome installation in its own node virtualenv, fixing the CI failure caused by npx not finding biome when node_modules is not installed.
  • Also excluded package-lock.json from biome formatting.

Note: test.yml line 116 also needs actions/setup-node@v6v4 (apply manually as workflow files require additional permissions).

Closes #77

Generated with Claude Code

Replace language: system (requires npx in CI) with language: node so
pre-commit manages biome installation via additional_dependencies.
This fixes the 100% failure rate caused by npx failing to find biome
when react_ui/node_modules is not installed in the pre-commit job.

Also exclude package-lock.json from biome formatting to prevent
machine-generated lock file from being altered by the formatter.

Co-authored-by: Lauri Gates <laurigates@users.noreply.github.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical failure in the test workflow by reconfiguring the biome-format pre-commit hook. The changes ensure that Biome is correctly installed and executed within the pre-commit environment, thereby stabilizing the CI process and preventing future build failures related to formatting.

Highlights

  • Pre-commit hook configuration: Updated the biome-format pre-commit hook in .pre-commit-config.yaml to use language: node with additional_dependencies instead of language: system and npx. This change ensures pre-commit manages Biome installation, resolving CI failures.
  • Biome exclusion: Added package-lock.json to the exclusion list for the biome-format hook to prevent unnecessary formatting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

finops: fix broken test workflow (100% failure rate)

1 participant