perf: code quality: enable Biome linter, expand ruff rules, fix lint issues by laurigates · Pull Request #82 · ForumViriumHelsinki/OLMap

laurigates · 2026-03-26T16:21:24Z

Frontend:

Enable Biome linter with recommended rules (was disabled)
Configure jsxRuntime as reactClassic for proper React import handling
Auto-fix: type-only imports, == to ===, template literals, optional chaining,
unused imports, let-to-const, literal keys, date constructors
Manual fixes: remove unused variables, add alt text, button types,
proper TypeScript types replacing any, remove empty destructuring patterns,
replace <></> with null, fix empty type aliases
Set error level for correctness rules, warn level for style/a11y for gradual cleanup

Backend:

Add PERF, PLE, PLW, PGH, FLY, FURB, PIE rule sets to ruff config
Auto-fix: unused noqa directives, import sorting
Fix explicit return in init methods (PLE0101)
Add noqa for intentional wildcard import in local_settings
Suppress RUF012 (mutable class variables) - too noisy for Django models
Add migration-specific ignores for T20, PERF, ARG001

Infrastructure:

Add biome lint step to just lint-frontend recipe

https://claude.ai/code/session_01V3hbn1ExGmpbJZrzF6zCs3

…t issues Frontend: - Enable Biome linter with recommended rules (was disabled) - Configure jsxRuntime as reactClassic for proper React import handling - Auto-fix: type-only imports, == to ===, template literals, optional chaining, unused imports, let-to-const, literal keys, date constructors - Manual fixes: remove unused variables, add alt text, button types, proper TypeScript types replacing `any`, remove empty destructuring patterns, replace `<></>` with null, fix empty type aliases - Set error level for correctness rules, warn level for style/a11y for gradual cleanup Backend: - Add PERF, PLE, PLW, PGH, FLY, FURB, PIE rule sets to ruff config - Auto-fix: unused noqa directives, import sorting - Fix explicit return in __init__ methods (PLE0101) - Add noqa for intentional wildcard import in local_settings - Suppress RUF012 (mutable class variables) - too noisy for Django models - Add migration-specific ignores for T20, PERF, ARG001 Infrastructure: - Add biome lint step to `just lint-frontend` recipe https://claude.ai/code/session_01V3hbn1ExGmpbJZrzF6zCs3

https://claude.ai/code/session_01V3hbn1ExGmpbJZrzF6zCs3

gemini-code-assist

Code Review

This pull request updates project dependencies, including a version bump for olmap and olmap_ui, and updates several Sentry packages. It also enhances the linting configuration by adding new rules to ruff and enabling biome for the frontend. Additionally, it cleans up various unused arguments in Python methods and improves TypeScript type imports. I have identified several critical issues where removing import React from 'react' breaks the build due to the reactClassic JSX runtime configuration, and I have provided feedback on improving unused argument handling.

gemini-code-assist · 2026-03-26T16:26:06Z

react_ui/src/App.test.js

@@ -1,4 +1,3 @@
-import React from 'react';
 import { render } from '@testing-library/react';


The jsxRuntime is set to reactClassic in biome.json, which requires React to be in scope when using JSX. Since this file uses JSX (<App />), removing the import React from 'react'; statement will cause a 'React is not defined' error. This import should be restored.

Suggested change

import { render } from '@testing-library/react';

import React from 'react';

import { render } from '@testing-library/react';

gemini-code-assist · 2026-03-26T16:26:06Z

react_ui/src/util_components/osm/api/UpdateWay.jsx

@@ -1,5 +1,3 @@
-import React from 'react';
-
 const UpdateWay = ({ changesetId, way }) => (


The jsxRuntime is set to reactClassic in biome.json, which requires React to be in scope when using JSX. Removing the import React from 'react'; statement will cause a 'React is not defined' error. This import should be restored.

import React from 'react'; const UpdateWay = ({ changesetId, way }) => (

gemini-code-assist · 2026-03-26T16:26:06Z

react_ui/src/util_components/osm/api/UpdateNode.jsx

@@ -1,5 +1,3 @@
-import React from 'react';
-
 const UpdateNode = ({ changesetId, node, tags }) => (


The jsxRuntime is set to reactClassic in biome.json, which requires React to be in scope when using JSX. Removing the import React from 'react'; statement will cause a 'React is not defined' error. This import should be restored.

import React from 'react'; const UpdateNode = ({ changesetId, node, tags }) => (

gemini-code-assist · 2026-03-26T16:26:06Z

react_ui/src/util_components/osm/api/CreateWay.jsx

@@ -1,5 +1,3 @@
-import React from 'react';
-
 const CreateWay = ({ changesetId, way }) => (


The jsxRuntime is set to reactClassic in biome.json, which requires React to be in scope when using JSX. Removing the import React from 'react'; statement will cause a 'React is not defined' error. This import should be restored.

import React from 'react'; const CreateWay = ({ changesetId, way }) => (

gemini-code-assist · 2026-03-26T16:26:06Z

react_ui/src/util_components/osm/api/CreateNode.jsx

@@ -1,5 +1,3 @@
-import React from 'react';
-
 const CreateNode = ({ changesetId, lon, lat, tags }) => (


The jsxRuntime is set to reactClassic in biome.json, which requires React to be in scope when using JSX. Removing the import React from 'react'; statement will cause a 'React is not defined' error. This import should be restored.

import React from 'react'; const CreateNode = ({ changesetId, lon, lat, tags }) => (

gemini-code-assist · 2026-03-26T16:26:07Z

django_server/olmap/rest/views/map_features.py

    @with_parameters(["name"])
    @action(methods=["GET"], detail=False)
-    def search(self, request, *args, **kwargs):  # noqa: ARG002
+    def search(self, request, *args, **kwargs):


The *args and **kwargs arguments are unused. They should be removed from the method signature to avoid ARG002 errors and improve clarity.

Suggested change

def search(self, request, *args, **kwargs):

def search(self, request):

gemini-code-assist · 2026-03-26T16:26:07Z

django_server/drf_jsonschema/converters.py

    field_class = serializers.PrimaryKeyRelatedField

-    def convert(self, field):  # noqa: ARG002
+    def convert(self, field):


The field argument is unused in this method. To signal that it's intentionally unused and to satisfy the ARG002 linting rule, you should prefix it with an underscore. This is a common Python convention and is cleaner than using a noqa comment.

This feedback applies to the convert methods in StringRelatedFieldConverter, HyperlinkedRelatedFieldConverter, and SlugRelatedFieldConverter as well.

Suggested change

def convert(self, field):

def convert(self, _field):

gemini-code-assist · 2026-03-26T16:26:07Z

django_server/olmap/rest/tests/__init__.py

 from .map_feature_tests import *
+from .osm_image_notes_tests import *
+from .rest_tests import *


Wildcard imports (from ... import *) are generally discouraged as they make it unclear which names are present in the namespace. This can lead to confusion and make the code harder to read and maintain. It seems the linter configuration now flags this (F403).

If these wildcard imports are necessary for the test suite setup, you should add a # noqa: F403 comment to each line to explicitly suppress the linting error. However, a better long-term solution would be to explicitly import the required names from each test module.

Suggested change

from .map_feature_tests import *

from .osm_image_notes_tests import *

from .rest_tests import *

from .map_feature_tests import * # noqa: F403

from .osm_image_notes_tests import * # noqa: F403

from .rest_tests import * # noqa: F403

gemini-code-assist · 2026-03-26T16:26:07Z

django_server/olmap/health.py



-def ready_check(request):  # noqa: ARG001
+def ready_check(request):


The request argument is unused. To signal this and comply with the ARG001 linting rule, you should prefix it with an underscore.

Suggested change

def ready_check(request):

def ready_check(_request):

gemini-code-assist · 2026-03-26T16:26:07Z

django_server/olmap/health.py



-def health_check(request):  # noqa: ARG001
+def health_check(request):


The request argument is unused. To signal this and comply with the ARG001 linting rule, you should prefix it with an underscore.

Suggested change

def health_check(request):

def health_check(_request):

laurigates · 2026-03-26T16:31:08Z

Let's address the recommendations in the comments. Evaluate which pieces of criticism and recommendations are substantive and valid. Act accordingly and refute invalid points.
@claude

claude · 2026-03-26T16:31:28Z

Claude finished @laurigates's task in 3m 31s —— View job

Review Comment Evaluation & Fixes

Gather context and evaluate all review comments
Fix unused parameter naming (health.py, converters.py, osm_image_note.py)
Push changes

Invalid Comments (Refuted)

"Critical": React import removals in .jsx/.js files

The reviewer's concern is incorrect. This project uses React 18 + react-scripts 5.0.1 (CRA), which uses Babel with the automatic JSX transform — import React is not required for JSX compilation. tsconfig.json's "jsx": "react" only affects TypeScript's type-checking of .tsx files; CRA's Babel compiles all JSX independently using runtime: "automatic". The jsxRuntime: "reactClassic" setting in biome.json is purely a linting hint telling Biome not to flag existing React imports as unused — it has no bearing on how Babel transforms JSX at build time. The removed imports in .jsx/.js files are correct.

Medium: Remove *args, **kwargs from detail=True action methods

DRF's dispatch calls action handlers as handler(request, *args, **kwargs) where pk is passed in kwargs for detail=True actions. Removing **kwargs from mark_reviewed, mark_accepted, mark_processed, hide_note, upvote, downvote, mark_seen would cause a TypeError at runtime when DRF passes the URL kwargs. These signatures must stay as-is.

Valid Fixes Implemented

Commit c845178:

health.py: Renamed request → _request in health_check and ready_check (ARG001 — signals intentional non-use)
converters.py: Renamed field → _field in StringRelatedFieldConverter, HyperlinkedRelatedFieldConverter, SlugRelatedFieldConverter (ARG002)
osm_image_note.py: Removed misleading pk=None parameter from map_feature_schemas (which is a detail=False action — DRF never passes a pk)

- Rename request -> _request in health_check and ready_check (ARG001) - Rename field -> _field in StringRelatedField, HyperlinkedRelatedField, SlugRelatedField converters (ARG002) - Remove spurious pk=None from map_feature_schemas (detail=False action) Co-authored-by: Lauri Gates <laurigates@users.noreply.github.com>

claude added 2 commits March 26, 2026 16:09

chore: update lock files

7b0ced3

https://claude.ai/code/session_01V3hbn1ExGmpbJZrzF6zCs3

github-actions bot changed the title ~~Improve code quality: enable Biome linter, expand ruff rules, fix lint issues~~ perf: code quality: enable Biome linter, expand ruff rules, fix lint issues Mar 26, 2026

gemini-code-assist bot reviewed Mar 26, 2026

View reviewed changes

laurigates merged commit 8916a7a into master Mar 26, 2026

laurigates deleted the claude/improve-code-quality-E03bB branch March 26, 2026 17:57

fvh-buildbot mentioned this pull request Mar 26, 2026

chore: release master #83

Open

		@@ -1,4 +1,3 @@
		import React from 'react';
		import { render } from '@testing-library/react';

		@@ -1,5 +1,3 @@
		import React from 'react';

		const UpdateWay = ({ changesetId, way }) => (

		@@ -1,5 +1,3 @@
		import React from 'react';

		const UpdateNode = ({ changesetId, node, tags }) => (

		@@ -1,5 +1,3 @@
		import React from 'react';

		const CreateWay = ({ changesetId, way }) => (

		@@ -1,5 +1,3 @@
		import React from 'react';

		const CreateNode = ({ changesetId, lon, lat, tags }) => (

	def search(self, request, args, *kwargs):
	def search(self, request):



		def ready_check(request): # noqa: ARG001
		def ready_check(request):



		def health_check(request): # noqa: ARG001
		def health_check(request):

Conversation

laurigates commented Mar 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

laurigates commented Mar 26, 2026

Uh oh!

claude bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Comment Evaluation & Fixes

Invalid Comments (Refuted)

Valid Fixes Implemented

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

claude bot commented Mar 26, 2026 •

edited

Loading