Use a more flexible health probe bind address to enable both IPv4 and… #2388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a more flexible health probe bind address to enable both IPv4 and IPv6 environments.
Currently, the sample deployment and default Helm chart installation fail in IPv4 environments - the fdb-operator pod crash loops with the following error:
This PR replaces the hard-coded IPv6 localhost address with a localhost spec that binds to whichever address family the system resolver prefers.
Type of change
Bug fix (non-breaking change which fixes an issue).
Discussion
We could alternatively update the Helm chart and/or deployment sample to override via the
--health-probe-bind-addressflag, but I think an IP-stack-agnostic default value probably makes the most sense.Testing
Tested manually on IPv4 (Google Kubernetes Engine standard cluster), and the change fixes the crash looping.
Documentation
I don't believe we need to add/update documentation for this one.