Lucene: index filters support #3688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottDugas
requested changes
Oct 22, 2025
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneOnlineIndexingTest.java
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneOnlineIndexingTest.java
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneOnlineIndexingTest.java
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneOnlineIndexingTest.java
Outdated
Show resolved
Hide resolved
...d-layer-lucene/src/main/java/com/apple/foundationdb/record/lucene/LuceneIndexMaintainer.java
Outdated
Show resolved
Hide resolved
ohadzeliger
requested changes
Oct 24, 2025
| assertNotEquals(needMerge, filterOut); | ||
| } | ||
|
|
||
| private TestRecordsTextProto.MapDocument multiEntryMapDoc(long id, String text, int group) { |
Contributor
There was a problem hiding this comment.
Maybe add a test that fails:
- filter returns
SOME - filter throws exception
ohadzeliger
approved these changes
Oct 28, 2025
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneIndexTestDataModel.java
Show resolved
Hide resolved
ScottDugas
requested changes
Nov 5, 2025
Collaborator
ScottDugas
left a comment
ScottDugas
left a comment
There was a problem hiding this comment.
We can discuss offline about the coupling between the test and LuceneIndexTestDataModel, I clearly had a vision for that that did not come through in the comments/code.
...ava/com/apple/foundationdb/record/provider/foundationdb/indexes/StandardIndexMaintainer.java
Show resolved
Hide resolved
...d-layer-lucene/src/main/java/com/apple/foundationdb/record/lucene/LuceneIndexMaintainer.java
Show resolved
Hide resolved
...d-layer-lucene/src/main/java/com/apple/foundationdb/record/lucene/LuceneIndexMaintainer.java
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneOnlineIndexingTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneOnlineIndexingTest.java
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Show resolved
Hide resolved
...d-layer-lucene/src/main/java/com/apple/foundationdb/record/lucene/LuceneIndexMaintainer.java
Show resolved
Hide resolved
ScottDugas
requested changes
Nov 7, 2025
...ene/src/main/java/com/apple/foundationdb/record/lucene/LuceneIndexScrubbingToolsMissing.java
Outdated
Show resolved
Hide resolved
Comment on lines
261
to
273
| try (FDBRecordContext context = openContext()) { | ||
| // overwrite records | ||
| dataModel.saveRecords(10, context, 2); | ||
| commit(context); | ||
| } | ||
|
|
||
| try (FDBRecordContext context = openContext()) { | ||
| // The same filter should apply to index scrubbing - else "missing" index entries will be detected | ||
| final long missingIndexEntries = dataModel.findMissingIndexEntries(context, null); | ||
| assertEquals(0, missingIndexEntries); | ||
| } |
Collaborator
There was a problem hiding this comment.
This test now seems even further from testing the scan functionality.
If you put the filter somewhere shareable, it should be pretty easy to put the testing of scrubbing in LuceneIndexScrubbingTest, and putting this others in LuceneIndexMaintenanceTest which feels appropriate to me. Although, maybe it would be best to just have a new class for filtered lucene indexes.
Perhaps not the highest priority though.
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
...ayer-lucene/src/test/java/com/apple/foundationdb/record/lucene/LuceneScanAllEntriesTest.java
Outdated
Show resolved
Hide resolved
ScottDugas
requested changes
Nov 7, 2025
...ene/src/main/java/com/apple/foundationdb/record/lucene/LuceneIndexScrubbingToolsMissing.java
Outdated
Show resolved
Hide resolved
ScottDugas
approved these changes
Nov 10, 2025
Add support for index filters by predicates or by IndexMaintenanceFilter. However, Lucene can only support ALL or NONE. Filtering SOME will cause an exception. Resolves FoundationDB#3065
jjezra
force-pushed
the
lucene_filter_records
branch
from
c294935 to
6746ecb
Compare
Contributor
Author
|
Rebase to "fix" line numbers and see if it affects Teamscale's Test Gaps. |
ScottDugas
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for index filters by predicates or by IndexMaintenanceFilter.
However, Lucene can only support ALL or NONE. Filtering SOME will cause an exception.
Resolves #3065