Added MacOS specific logic to overcome missing embedded window calls.#484
Open
sax1johno wants to merge 3 commits intoFreeCAD:masterfrom
Open
Added MacOS specific logic to overcome missing embedded window calls.#484sax1johno wants to merge 3 commits intoFreeCAD:masterfrom
sax1johno wants to merge 3 commits intoFreeCAD:masterfrom
Conversation
Collaborator
|
Hello, Thank you for your kind contribution! However, before modifying the code: In Render preferences, there is a checkbox named "Disable GUI embedding". Can you try it beforehand? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #480 it was reported that on MacOS, the Render workbench was crashing when attempting to open the embedded window for downloading materials.
In QT versions below 6.0, there is only buggy or sporadic support for
QWindow.fromWinId, the method that is used to attach embedded windows to the main window context. This causes a crash whenever the workbench attempts to create an embedded window.This PR provides a workaround patch that displays a message on Mac OSX letting users know that the embedding is not support, and then exits. This allows the window to open as a separate window, rather than an embedded window.
This should fix #480 until Freecad is upgraded to a version that supports QWindow.fromWinId on MacOSX, or else that change is backported to QT 5.xx.