This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Dynamic callback URL + updated description#49
Open
vinceve wants to merge 2 commits intoFriendsOfSymfony:masterfrom
vinceve:master
Open
Dynamic callback URL + updated description#49vinceve wants to merge 2 commits intoFriendsOfSymfony:masterfrom vinceve:master
vinceve wants to merge 2 commits intoFriendsOfSymfony:masterfrom
vinceve:master
Conversation
added 2 commits
February 10, 2013 19:54
Member
There was a problem hiding this comment.
Simply remove this line entirely. It is not needed when the class can be autoloaded, which should be the case when installing the lmibrary through Composer (otherwise, it should be fixed in their composer.json)
|
@vinceve : I've submitted a PR a few days ago with almost the same changes, imo you should just keep the method for the callback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added a setter for callback URL to make it dynamic. Now it should be possible to determine at runtime the callback url. This could be used in specific places.
I also edited the README file for a more accurate description.