Feature: Remember the previous window position & size#30
Feature: Remember the previous window position & size#30grassified wants to merge 2 commits intoFrogSnot:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded a window-state plugin: npm and Cargo dependencies were added, the plugin was registered in the Tauri builder, and the default Tauri capability permissions were updated to include Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src-tauri/src/lib.rs`:
- Line 20: The tauri_plugin_window_state plugin is registered via
tauri_plugin_window_state::Builder::default().build() but the corresponding
capability is missing; open the capabilities JSON for the "default" capability
(identifier "default") and add "window-state:default" to the "permissions" array
so it includes
["core:default","notification:default","dialog:default","window-state:default"];
ensure the capability object still contains identifier "default", description,
and windows (e.g., "main") entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 98533d18-d290-470a-a747-48d8bca711e4
⛔ Files ignored due to path filters (5)
package-lock.jsonis excluded by!**/package-lock.jsonsrc-tauri/Cargo.lockis excluded by!**/*.locksrc-tauri/gen/schemas/acl-manifests.jsonis excluded by!**/gen/**src-tauri/gen/schemas/desktop-schema.jsonis excluded by!**/gen/**src-tauri/gen/schemas/linux-schema.jsonis excluded by!**/gen/**
📒 Files selected for processing (3)
package.jsonsrc-tauri/Cargo.tomlsrc-tauri/src/lib.rs
Description
This PR adds the functionality to remember window positions & sizes from the previous app shutdown.
This change requires adding two new dependencies:
These are official Tauri plugins designed to be extremely lightweight and probably the best options for this feature.
The Sunder Checklist
reqwestor TLS) without discussing it in an issue first.cargo fmtandcargo clippylocally.Summary by CodeRabbit