Skip to content

Conversation

@MitchTurner
Copy link
Member

@MitchTurner MitchTurner commented Mar 18, 2025

Attempt at understanding the work required to do FuelLabs/fuel-core#2821

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@MitchTurner MitchTurner marked this pull request as draft March 18, 2025 22:56
@MitchTurner MitchTurner self-assigned this Mar 19, 2025
@MitchTurner
Copy link
Member Author

MitchTurner commented Mar 20, 2025

@xgreenx @Dentosal

IS this a viable approach: creating a new output/input type for the DataCoin? Or should we just add an Optionof data to Coin?

Also, Output isn't Clone so I just attached a hash of the data, but Idk how we include the data then. On the Tx? and then it can be indexed somewhere.

I'm guessing you guys are more familiar with the vm and might have some ideas.

@Dentosal
Copy link
Member

IS this a viable approach: creating a new output/input type for the DataCoin? Or should we just add an Optionof data to Coin?

Also, Output isn't Clone so I just attached a hash of the data, but Idk how we include the data then. On the Tx? and then it can be indexed somewhere.

I'm guessing you guys are more familiar with the vm and might have some ideas.

We could probably make Output Clone it that helps? The whole input/output code is rather messy so I'm not sure what's the best approach code-wise. DataCoin approach should be viable as well. I don't actually understand what the data output is exactly for, though, so I'm not sure what's the best approach here.

@MitchTurner
Copy link
Member Author

@Dentosal maybe we can set up a call to knowledge share some context on how we store outputs and how they differ from inputs. I agree the code is a bit of a mess lol.

@MitchTurner MitchTurner changed the title Naively add new ouput and input types for data Prototype: Naively add new ouput and input types for data Apr 1, 2025
@MitchTurner MitchTurner changed the title Prototype: Naively add new ouput and input types for data Prototype: Add DataCoin to inputs and outputs Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants