Skip to content

[ENHANCEMENT] Reduce volume when focus is lost #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AbnormalPoof merged 1 commit into from
Nov 23, 2025
Merged

[ENHANCEMENT] Reduce volume when focus is lost #6250

AbnormalPoof merged 1 commit into from
Nov 23, 2025

Conversation

@PurSnake
Copy link
Contributor

@PurSnake PurSnake commented Oct 9, 2025 •
edited
Loading

Linked Issues

#6021

Description

Adds new define on compilation for desktop platforms, to reduce game volume, when user unfocuses it.

@github-actions github-actions bot added status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. labels Oct 9, 2025
@PurSnake
Copy link
Contributor Author

PurSnake commented Oct 9, 2025

Someone probably will request some changes
Im down for them

TechnikTil
TechnikTil reviewed Oct 10, 2025
View reviewed changes
@github-actions github-actions bot added the size: large A large pull request with more than 100 changes. label Oct 10, 2025
@Hundrec Hundrec added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Oct 12, 2025
@Hundrec Hundrec changed the title [ENHANCEMENT] Feature - Lost/Gain Application Focus Volume Change [ENHANCEMENT] Option to reduce volume when focus is lost Oct 14, 2025
@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Oct 20, 2025
@Hundrec
Copy link
Member

Hundrec commented Oct 20, 2025

Got some notes for this PR:

  • This is a good idea! The team likes it
  • This should not be an option, so you should remove the Preference altogether.
  • It should be "Instant", and it should be set to 50% volume.

The key thing is that this shouldn't be an option, so the game will always cut the volume in half on focus loss.
Please make these changes and I'll pull this in for review!

@Hundrec Hundrec linked an issue Oct 20, 2025 that may be closed by this pull request
Enhancement: Lower game volume when losing focus #6021
Open
3 tasks
@PurSnake
Copy link
Contributor Author

PurSnake commented Oct 20, 2025

Okaye

@TechnikTil
Copy link
Contributor

TechnikTil commented Oct 20, 2025

also theres merge conflicts

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. and removed size: large A large pull request with more than 100 changes. labels Oct 20, 2025
@PurSnake PurSnake force-pushed the feature-lost-focuse-volume-shit branch from 6cc1cfe to 8bd95b4 Compare October 20, 2025 16:57
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. size: medium A medium pull request with 100 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. size: large A large pull request with more than 100 changes. labels Oct 20, 2025
@PurSnake PurSnake changed the title [ENHANCEMENT] Option to reduce volume when focus is lost [ENHANCEMENT] Reduce volume when focus is lost Oct 20, 2025
@PurSnake
Copy link
Contributor Author

PurSnake commented Oct 20, 2025

Done

@Hundrec Linear
Copy link
Member

Hundrec commented Oct 20, 2025

Yay thank you

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Oct 23, 2025
@PurSnake PurSnake force-pushed the feature-lost-focuse-volume-shit branch from 72ed6ee to 3f6f9a5 Compare November 20, 2025 14:49
@github-actions github-actions bot added size: huge A huge pull request with more than 500 changes. size: medium A medium pull request with 100 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. size: huge A huge pull request with more than 500 changes. labels Nov 20, 2025
@PurSnake PurSnake force-pushed the feature-lost-focuse-volume-shit branch from 7c9c855 to 3391407 Compare November 20, 2025 14:52
@Hundrec Hundrec self-requested a review November 21, 2025 08:31
@AbnormalPoof AbnormalPoof force-pushed the feature-lost-focuse-volume-shit branch from 3391407 to 7e1e17d Compare November 23, 2025 11:21
@AbnormalPoof AbnormalPoof added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Nov 23, 2025
@AbnormalPoof AbnormalPoof changed the base branch from develop to dummy/develop-v0.7.5 November 23, 2025 11:24
@AbnormalPoof AbnormalPoof added this to the 0.7.6 milestone Nov 23, 2025
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Nov 23, 2025
@AbnormalPoof AbnormalPoof merged commit 3083b94 into FunkinCrew:dummy/develop-v0.7.5 Nov 23, 2025
6 checks passed
@Hundrec Hundrec removed their request for review November 23, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TechnikTil TechnikTil TechnikTil left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.

Milestone

0.7.6

Development

Successfully merging this pull request may close these issues.

Enhancement: Lower game volume when losing focus

4 participants

@PurSnake @Hundrec @TechnikTil @AbnormalPoof