Skip to content

[OPTIMIZATION] Unify player/opponent voice list builders into one function using CharacterType #6295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Starexify wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[OPTIMIZATION] Unify player/opponent voice list builders into one function using CharacterType #6295

Starexify wants to merge 1 commit into from

Conversation

@Starexify
Copy link

@Starexify Starexify commented Oct 17, 2025 •
edited
Loading

Description

This PR unifies the functions buildOpponentVoiceList and buildPlayerVoiceList into a single buildVoiceListForCharacter function, which uses CharacterType to determine which vocal list to build.

Also removes the $suffix from the second checking, which prevented normal vocals from characters to be searched for, such as Vocals-bf if there is no Vocals-bf-car-variation or Vocals-bf-variation

@github-actions github-actions bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. labels Oct 17, 2025
@AbnormalPoof
Copy link
Member

AbnormalPoof commented Oct 17, 2025

FYI this is not a chore since it makes a functional change

@AbnormalPoof AbnormalPoof added the type: optimization Involves a performance issue or a bug which causes lag. label Oct 17, 2025
@AbnormalPoof AbnormalPoof changed the title [CHORE] Unify player/opponent voice list builders into one function using CharacterType [OPTIMIZATION] Unify player/opponent voice list builders into one function using CharacterType Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. type: optimization Involves a performance issue or a bug which causes lag.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Starexify @AbnormalPoof