Fix wrong checks for NaN throughout the code #6344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
moxie-coder
approved these changes
Oct 24, 2025
|
LGTM! |
EliteMasterEric
approved these changes
Oct 29, 2025
Member
EliteMasterEric
left a comment
EliteMasterEric
left a comment
There was a problem hiding this comment.
Looks good, did some checking and yea, Math.NaN is implemented such that it is equal to no other value (even Math.NaN == Math.NaN returns false).
NotHyper-474
force-pushed
the
fix/wrong-nan-check
branch
from
5fea3e8 to
e1d4781
Compare
NotHyper-474
force-pushed
the
fix/wrong-nan-check
branch
from
e1d4781 to
0dcabdf
Compare
Hundrec
added
status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wrong checks for NaN, the
Math.isNaNfunction should be used instead of comparing the values because it's always gonna beFalse...https://try.haxe.org/#6ea88699
^ You can see how
Math.isNaNreturns the correct result here