[ENHANCEMENT] Week 7 Cutscenes no longer a video (feat. @CrusherNotDrip) #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: huge
Contributor
Author
|
This is also currently on the |
|
@TechnikTil I don't have the ability to change stuff u liar liar pants on fire |
TechnikTil
changed the title
Contributor
Author
oopsie sorry |
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
4b2a448 to
c9baff0
Compare
Contributor
Author
|
this MIGHT get annoying |
github-actions
bot
added
pr: hscript
|
Just realizing we pushed the commented out story mode check Don't worry about that we were planning on putting that back anyways, we just removed it for convince (better than hitting 1 at least 2 times to see a cutscene) |
Contributor
Author
|
Ready! |
|
not ready we forgot skipping |
sphis-sinco
reviewed
Sep 11, 2025
sphis-sinco
reviewed
Sep 11, 2025
Contributor
Author
|
should be free of whatever you wanna call it |
preload/scripts/songs/stress.hxc
Outdated
|
|
||
| cutsceneMusic = FunkinSound.load(Paths.music(musicPath, "week7"), 1, false); | ||
|
|
||
| // we will ALL be calling daddy dearest daddy |
Contributor
Author
There was a problem hiding this comment.
i meant to get rid of this too 😭
go go another commit
AbnormalPoof
requested changes
Sep 11, 2025
Member
AbnormalPoof
left a comment
AbnormalPoof
left a comment
There was a problem hiding this comment.
Not a bad start! Some notes:
- Camera movements aren't completely accurate, you can reference legacy's code for more accurate camera movements: https://github.com/FunkinCrew/Funkin/tree/legacy/0.2.x
- Dave says the music should fade out instead of abruptly stopping.
- Dave says BF should not bop to the beat. This likely applies to the stage props as well.
- For GF turning demon, you can quickly swap out the atlas for a sparrow, as that animation uses a blend mode that currently doesn't work properly in-game.
preload/scripts/songs/stress.hxc
Outdated
Comment on lines
146
to
151
| picoCutscene.anim.addByFrameLabel("gfTurn", "gf turns demon", 24, false); | ||
| picoCutscene.setAnimationOffsets("gfTurn", 0, 0); | ||
| picoCutscene.anim.addByFrameLabel("picoSaves", "obliteration", 24, false); | ||
| picoCutscene.setAnimationOffsets("picoSaves", 0, 0); | ||
| picoCutscene.anim.addByFrameLabel("idle", "pico idle", 24, false); | ||
| picoCutscene.setAnimationOffsets("idle", 0, 0); |
Member
There was a problem hiding this comment.
should maybe reorder this:
Suggested change
| picoCutscene.anim.addByFrameLabel("gfTurn", "gf turns demon", 24, false); | |
| picoCutscene.setAnimationOffsets("gfTurn", 0, 0); | |
| picoCutscene.anim.addByFrameLabel("picoSaves", "obliteration", 24, false); | |
| picoCutscene.setAnimationOffsets("picoSaves", 0, 0); | |
| picoCutscene.anim.addByFrameLabel("idle", "pico idle", 24, false); | |
| picoCutscene.setAnimationOffsets("idle", 0, 0); | |
| picoCutscene.anim.addByFrameLabel("gfTurn", "gf turns demon", 24, false); | |
| picoCutscene.anim.addByFrameLabel("picoSaves", "obliteration", 24, false); | |
| picoCutscene.anim.addByFrameLabel("idle", "pico idle", 24, false); | |
| picoCutscene.setAnimationOffsets("gfTurn", 0, 0); | |
| picoCutscene.setAnimationOffsets("picoSaves", 0, 0); | |
| picoCutscene.setAnimationOffsets("idle", 0, 0); |
preload/scripts/songs/guns.hxc
Outdated
| }); | ||
|
|
||
| gfSadAnim(); | ||
| PlayState.instance.currentStage.getGirlfriend().animation.onFinish.add(gfSadAnim); |
Member
There was a problem hiding this comment.
you can just set PlayState.instance.currentStage.getGirlfriend().animation.curAnim.looped instead of doing this
AbnormalPoof
added
type: enhancement
Contributor
Author
As per the PR description:
Will keep that in mind for the next commit.
Will keep that in mind for next commit, does GF count? She bops her head in the original cutscene.
I'm working with Better TA to fix this issue, as it has a feature to bake the blends inside of the spritemap. |
AbnormalPoof
force-pushed
the
feat/flixel-animate
branch
from
2497ef4 to
76f9911
Compare
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
c5b789f to
25a4206
Compare
Contributor
Author
|
i really gotta squash this sometime soon |
Contributor
Author
|
also ill keep this as a draft for now |
AbnormalPoof
force-pushed
the
feat/flixel-animate
branch
3 times, most recently
from
4ee5c71 to
515c3ed
Compare
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
e481a43 to
7509aae
Compare
Contributor
Author
|
someone please remind me to squash this once the PR is ready for review again |
github-actions
bot
added
the
pr: chart
AbnormalPoof
force-pushed
the
feat/flixel-animate
branch
from
b5aac82 to
c01f25f
Compare
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
2 times, most recently
from
ed99158 to
ebe2c47
Compare
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
ebe2c47 to
7cff567
Compare
CrusherNotDrip
suggested changes
Oct 21, 2025
CrusherNotDrip
approved these changes
Oct 21, 2025
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
84e91f8 to
569cb58
Compare
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
569cb58 to
aed9bd8
Compare
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
aed9bd8 to
fcfa9a1
Compare
AbnormalPoof
added
status: pending triage
Contributor
Author
|
YESSSSS |
Contributor
Author
|
LETSS GOOOO |
Commit Names: - Export Tankman and Pico (GF) atlases with Better TA - Ugh & Guns progress made. - goddamn it - Stress Cutscene, and Pico re-export. - TechnikStupid - this dude only fixed it for stress - Clean Up - tiny changes to keep dave happy (and others) - ugh cutscene skipping - Re-export atlases. - Guns + Stress skipping and tiny patch ups - More accurate camera positions and tiny fixes - Subtitles (Work in Progress) - final touch ups, getting ready to squash - shit shit shit shit shit shit shit - destroy subtitles early (since u can see them above `camCutscene`), also run formatter Co-authored-by: CrusherNotDrip <crushernotdrip@tilnotdrip.org> Signed-off-by: TechnikTil <techniktil@tilnotdrip.org>
TechnikTil
force-pushed
the
feat/week7-realtime-cutscenes
branch
from
fcfa9a1 to
198099c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Supersedes #32
What is this pull request?
This Pull Request redoes the Week 7 cutscenes but everything happens in-game instead of as a video.
Here is a video of them (It may look like the mp4 but even poorer quality (had to compress it) but it shows the countdown transition so u can still kinda see what its like in-game):
8mb.video-b4A-5b9wdpoT.mp4
Linked Issues
FunkinCrew/Funkin#3324