[OPTIMIZATION] Clean up ending cutscene logic for Blazin' #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: medium
ender69is4real
changed the title
ender69is4real
changed the title
ender69is4real
changed the title
Hundrec
added
status: pending triage
- Changes bgSprite to fade - Removes cleanupTankmanGroup because only uses for only kill function so this is useless - little cleanup
Hundrec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the sprite to camera visible. So ending cutscene will be optimized.
Also removes
onNoteHit()because he doesn't do anything. Also tested on a mobile, so it works.