Skip to content

Type mismatch in dateFilter between NgxMatDatetimePickerInputV2 and b… #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crathje wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Type mismatch in dateFilter between NgxMatDatetimePickerInputV2 and b… #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/datetime-picker/src/lib/datetime-picker-input-v2.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ export class NgxMatDatetimePickerInputV2<D>

/** Function that can be used to filter out dates within the datepicker. */
@Input()
get dateFilter(): (date: D) => boolean {
get dateFilter(): (date: D | null) => boolean {
return this._dateFilter();
}
set dateFilter(value: (date: D) => boolean) {
set dateFilter(value: (date: D | null) => boolean) {
const wasMatchingValue = this._matchesFilter(this.value);
this._dateFilter.set(value);
if (this._matchesFilter(this.value) !== wasMatchingValue) {
Expand Down