Support enum class in struct-backed type #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flakebi
reviewed
Nov 13, 2025
Comment on lines
+312
to
+315
| if ((uint64_t)$0 == 0) | ||
| $fields.push_back(::llvm::StructType::get($_context)); | ||
| else | ||
| $fields.push_back(::llvm::IntegerType::get($_context, $0)); | ||
| $fields.push_back(::llvm::IntegerType::get($_context, (uint64_t)$0)); |
Member
There was a problem hiding this comment.
The conversions here and above should use getToUnsigned and getFromUnsigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may use enumeration class in struct backed type, which makes struct type more semantic. However, we need to force these values to be cast from integers to the target type.