Merged
Conversation
…cents, ampersands, and parentheses, and removing the `_pdflince` suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where users were unable to include spaces in custom filenames when using the Merge PDF tool.
Previously, an aggressive
.trim()functioned on every keystroke, immediately deleting any trailing spaces the user typed. Additionally, the filename generation logic was overly restrictive, stripping out safe characters (like&,(,), and accented letters) and replacing intentional spaces with underscores during the download process.Changes made:
.trim()on themetadata.titleinput field, allowing users to type spaces naturally.buildFileNamein index.tsx to use a more permissive regex (/[^\p{L}\p{N}\-_ &()]/gu) that preserves spaces, unicode letters (likeñor accents), ampersands, and parentheses in the final downloaded filename._pdflincegeneric suffix when a user explicitly provides a custom title.Fixes # (issue)
Type of change
How Has This Been Tested?
The changes were tested manually in the browser and verified against the existing automated browser test suite.
npm run test:e2e): Verified that the PDF Merge Workflow tests still pass successfully and that the changes do not break other existing processing tools. (Note: minor local fixture errors insmoke.spec.tsare unrelated to this PR).Checklist:
Thanks Sara for finding the bug :)