Skip to content

use AspectList.remove instead of AspectList.reduce to fix "sometimes drainer doesn't work with essentia import bus"#56

Merged
Dream-Master merged 8 commits intoGTNewHorizons:masterfrom
SST-03:patch-1
Feb 2, 2026
Merged

use AspectList.remove instead of AspectList.reduce to fix "sometimes drainer doesn't work with essentia import bus"#56
Dream-Master merged 8 commits intoGTNewHorizons:masterfrom
SST-03:patch-1

Conversation

@SST-03
Copy link

@SST-03 SST-03 commented Sep 29, 2025

use AspectList.remove(...) instead of .reduce(...) can remove Aspect when aspect.amount==0.
closes GTNewHorizons/GT-New-Horizons-Modpack#20653

@Dream-Master Dream-Master requested a review from a team September 29, 2025 07:57
@SST-03
Copy link
Author

SST-03 commented Sep 29, 2025

wait how does build and test fail
why?????

org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find com.github.GTNewHorizons:Postea:1.1.1.

But why? I think it's not related to my pr.

@Dream-Master
Copy link
Member

Some mod use postea or postea is set in dev in this mod. To resolve it run gradlew updatebuildscript or found the mod run it there add a new tag and update this mod .

@SST-03
Copy link
Author

SST-03 commented Sep 29, 2025

Some mod use postea or postea is set in dev in this mod. To resolve it run gradlew updatebuildscript or found the mod run it there add a new tag and update this mod .

I used .\gradlew updatebuildscript and upload changes to github, but still, it just not works. Do I need to do other things?

@SST-03
Copy link
Author

SST-03 commented Sep 29, 2025

ok finally build successful.
let me try if this can fix bug...

@Dream-Master
Copy link
Member

The mod cause it is now updated and all fine

@SST-03 SST-03 changed the title Try to fix drainer bug use AspectList.remove instead of AspectList.reduce to fix "sometimes drainer doesn't work with essentia import bus" Sep 29, 2025
@SST-03
Copy link
Author

SST-03 commented Sep 29, 2025

I think it's almost all done, waiting for merge. This patch cannot fix exists drainer so I recommend players to break drainer and place it again.
Also it will not break automation that use drainer(s) to get aspect(s).

@Dream-Master
Copy link
Member

I think it's almost all done, waiting for merge. This patch cannot fix exists drainer so I recommend players to break drainer and place it again. Also it will not break automation that use drainer(s) to get aspect(s).

@SST-03 are you on GTNH Discord?

@SST-03
Copy link
Author

SST-03 commented Sep 29, 2025

@SST-03 are you on GTNH Discord?

At least now, yes. (i don't often use discord)

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Oct 1, 2025
@Nikolay-Sitnikov Nikolay-Sitnikov self-assigned this Feb 1, 2026
Copy link

@Nikolay-Sitnikov Nikolay-Sitnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dream-Master Dream-Master merged commit 9ce571f into GTNewHorizons:master Feb 2, 2026
1 check passed
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the apimancer's drainer work with essentia import busses After change essentia-type of drainer

3 participants

Comments