ignore "," when searching numbers + support searching some elements by pinyin + a special searching mode to search voltage names and machine names separate#4
Merged
serenibyss merged 40 commits intoGTNewHorizons:masterfrom Mar 15, 2025
Conversation
serenibyss
reviewed
Feb 28, 2025
serenibyss
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My English is bad.
some features are disabled in default config and can be opened in NotEnoughCharacters.cfg.
if users search "65,536" (or other texts with ","), "," will not be ignored.
else, for example if user search "655", items like "uiv 65,536 hatch" will be searched.
this feature is set to disable in config (B:EnableIgnoreComma=true)
now people can search elements like 𫟷(Lv) by using pinyin.
when people search something with voltage names (like “IV能源仓”/IV Energy Hatch), they can just search "ivnyc", for this example nech will try to match items with "iv" and "nyc", just like searching "iv nyc".
this feature is set to disable in config (B:EnableVoltageSpecialSearchName=true, B:EnableVoltageSpecialSearchTooltips=true)