Add ability to toggle fn lock/fix game mode not hiding #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really nice! I will review the code and merge this PR as soon as I can! |
|
Thanks! What do you think about writing to some file in no rush btw :) |
|
Nice idea to have such a switch in the software. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My blade stealth doesn't support game mode but when I open the application, the switch still shows. If I select my device in the dropdown it hides like it's supposed to. I made the container of the switch no_show_all and that seemed to fix the problem.
In my device folder (
/sys/bus/hid/drivers/razerkbd/<DEVICE ID>/) there is a file calledfn_toggle. Writing a 1 or 0 to this file changes the behavior of the F keys (like fn lock, which my keyboard does not have). I added a switch to the right of the game mode switch that only shows if the selected device has afn_togglefile.Unfortunately there is nothing in the razer-drivers python client for this fn lock functionality, so I opted to just write directly to
fn_toggle. Furthermore,fn_toggleis write only, so the switch may not accurately show if 'fn-lock' is on/off.I'm not sure if this feature has enough demand to justify these somewhat sketchy additions, but please let me know what you think!