Skip to content

Fix: auto-scroll tab bar to active tab #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabko14 merged 1 commit into from
Feb 25, 2026
Merged

Fix: auto-scroll tab bar to active tab #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 37 additions & 24 deletions Ghostly/Views/TabBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,46 @@ struct TabBarView: View {

var body: some View {
VStack(spacing: 0) {
ScrollView(.horizontal, showsIndicators: false) {
HStack(spacing: 2) {
ForEach(tabManager.tabs) { tab in
TabItemView(
tab: tab,
isActive: tab.id == tabManager.activeTabId,
onSelect: { tabManager.selectTab(tab.id) },
onClose: { tabManager.closeTab(tab.id) }
)
}
ScrollViewReader { proxy in
ScrollView(.horizontal, showsIndicators: false) {
HStack(spacing: 2) {
ForEach(tabManager.tabs) { tab in
TabItemView(
tab: tab,
isActive: tab.id == tabManager.activeTabId,
onSelect: { tabManager.selectTab(tab.id) },
onClose: { tabManager.closeTab(tab.id) }
)
.id(tab.id)
}

// Plus button to add new tab
Button {
tabManager.newTab()
} label: {
Image(systemName: "plus")
.font(.system(size: 11, weight: .medium))
.foregroundStyle(Color.catOverlay)
.frame(width: 24, height: 24)
.contentShape(Rectangle())
// Plus button to add new tab
Button {
tabManager.newTab()
} label: {
Image(systemName: "plus")
.font(.system(size: 11, weight: .medium))
.foregroundStyle(Color.catOverlay)
.frame(width: 24, height: 24)
.contentShape(Rectangle())
}
.buttonStyle(.plain)
.opacity(0.7)
.accessibilityIdentifier("newTabButton")
}
.padding(.horizontal, 8)
.padding(.vertical, 4)
}
.onAppear {
guard let activeId = tabManager.activeTabId else { return }
proxy.scrollTo(activeId, anchor: .center)
}
.onChange(of: tabManager.activeTabId) { _, newId in
guard let newId else { return }
withAnimation(.easeInOut(duration: 0.2)) {
proxy.scrollTo(newId, anchor: .center)
}
.buttonStyle(.plain)
.opacity(0.7)
.accessibilityIdentifier("newTabButton")
}
.padding(.horizontal, 8)
.padding(.vertical, 4)
}
.frame(height: 34)

Expand Down