Skip to content

revert: remove pin feature (rethinking approach)#63

Merged
Gabko14 merged 1 commit intomainfrom
revert/pin-feature
Feb 28, 2026
Merged

revert: remove pin feature (rethinking approach)#63
Gabko14 merged 1 commit intomainfrom
revert/pin-feature

Conversation

@Gabko14
Copy link
Copy Markdown
Owner

@Gabko14 Gabko14 commented Feb 28, 2026

Reverting #62 — the pin button approach is wrong. Need to rethink from first principles.

…n-pinned"

This reverts commit fb2cb72, reversing
changes made to d2fefbe.
@Gabko14 Gabko14 merged commit b56fbef into main Feb 28, 2026
2 checks passed
@Gabko14 Gabko14 deleted the revert/pin-feature branch February 28, 2026 22:49
@claude
Copy link
Copy Markdown

claude bot commented Feb 28, 2026

Review

This revert PR cleanly removes the pin feature introduced in #62. The changes look correct:

What's being reverted:

  • isPinned property removed from AppState (including UserDefaults persistence)
  • Pin button UI removed from HeaderView
  • Local MenuBarExtraAccess package fork deleted (1,100+ lines)
  • Returns to upstream MenuBarExtraAccess package from orchetect/MenuBarExtraAccess

Code quality observations:

  1. Clean revert — All pin-related code paths are properly removed. No orphaned references.

  2. HeaderView signature simplified — Changed from taking AppState to just SettingsManager, which is a better pattern (only pass what's needed.

  3. Package.resolved regenerated — The remote dependency is properly configured with requirement starting at 1.0.0.

  4. No leftover UserDefaults — Note that may still exist in users' UserDefaults from fix: keep window open when pinned #62, but this is harmless (orphaned key, no cleanup needed).

Suggestion for future implementation:
The original approach of forking the upstream package to add behavior is a maintenance burden. When revisiting this feature, consider:

  • Opening an upstream PR to with the functionality
  • Using SwiftUI's native window management if available in newer macOS versions
  • Implementing a standalone NSWindow approach instead of modifying the panel behavior

LGTM — straightforward revert with no issues.
EOF
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant