-
Notifications
You must be signed in to change notification settings - Fork 1.8k
GitHub Actions: Test on Python 3.14 #2627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The remaining issues are about itertools not being serialisable anymore in 3.14. We'll have to change the implementation of the relevant functions to not use a deep copy etc. @Arusekk mentioned #1665 needed similar treatment when multiprocessing changed the default start method on macos. This came to Linux now too. python/cpython#84559 |
|
|
I almost got it, I decided to augment pickle with marshal for mbruteforce. This will also be a better fix for the original macOS issue, hopefully. As for iters.lookahead, I think we can just drop it? It seems that it was broken (inefficient, wrong edge case handling) right from the start, as the Python issue says. Just a single function, no internal uses, and supposedly little uses outside (not many comments or links to that issue). |
|
Rock and roll! 🚀 |
Continues the work started in: * Gallopsled#2627
Python 3.14 (the π version)
https://www.python.org/downloads/release/python-3140/
https://github.com/actions/python-versions/releases
Pwntools Pull Request
Thanks for contributing to Pwntools! Take a moment to look at
CONTRIBUTING.mdto make sure you're familiar with Pwntools development.Please provide a high-level explanation of what this pull request is for.
Testing
Pull Requests that introduce new code should try to add doctests for that code. See
TESTING.mdfor more information.Target Branch
Depending on what the PR is for, it needs to target a different branch.
You can always change the branch after you create the PR if it's against the wrong branch.
devdevstablestablebranchbetabetabranch, but notstabledevChangelog
After creating your Pull Request, please add and push a commit that updates the changelog for the appropriate branch.
You can look at the existing changelog for examples of how to do this.