Merged
Conversation
This means we no longer directly invoke `uv run` on a script with PEP 723 metadata; instead we use `uv venv` and `uv pip install` before calling python directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #127
In terms of outward-facing changes this is just a pretty straightforward performance enhancement, but internally it's a little more significant. In order to re-use virtual environments, we needed to refactor the shell script template from a nice implicit
uv runto explicitly building an environment withuv venv+uv pip installto run the script. The upshot of this is that uv isn't actually parsing any of the PEP723 metadata itself anymore -- the resolution logic is equivalent for a fresh script, but groundhog is now the only tool reading the metadata, and so is responsible for faithfully passing the metadata (e.g.exclude-newer) along to uv.