Skip to content

fix: max score #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hib4 merged 1 commit into from
Jun 25, 2025
Merged

fix: max score #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/applications/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,17 +898,17 @@ export default function Applications() {
<div className="space-y-4">
<div>
<label className="block text-sm font-medium text-white mb-2">
Score (0-10)
Score (0-20)
</label>
<input
type="number"
min="0"
max="10"
max="20"
step="0.1"
value={evaluationScore}
onChange={(e) => setEvaluationScore(e.target.value)}
className="input w-full"
placeholder="Enter score (0-10)"
placeholder="Enter score (0-20)"
/>
</div>
<div>
Expand Down
6 changes: 3 additions & 3 deletions components/ApplicationAcceptModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ export default function ApplicationAcceptModal({ setShowAcceptModal }: Applicati

const onChangeMinScore = (e: React.ChangeEvent<HTMLInputElement>) => {
const value = Number(e.target.value)
if (value < 0 || value > 10) {
setMinScoreError("Score must be between 0 and 10")
if (value < 0 || value > 20) {
setMinScoreError("Score must be between 0 and 20")
} else {
setMinScore(value)
setMinScoreError("")
Expand Down Expand Up @@ -254,7 +254,7 @@ export default function ApplicationAcceptModal({ setShowAcceptModal }: Applicati
className="bg-transparent border border-white/20 rounded-md px-4 py-2 text-white w-full"
placeholder="Minimum score"
min={0}
max={10}
max={20}
onChange={onChangeMinScore}
/>
<span className="text-red-500 text-xs text-end">{minScoreError}</span>
Expand Down
2 changes: 1 addition & 1 deletion lib/firebaseUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ export async function updateUserStatus(userId: string, status: string): Promise<
/**
* Updates an application's score and evaluation notes in Firestore
* @param applicationId - The ID of the application to update
* @param score - The numerical score (0-10)
* @param score - The numerical score (0-20)
* @param evaluationNotes - Optional evaluation notes
*/
export async function updateApplicationScore(
Expand Down
42 changes: 39 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.