fix: detour accuracy rewrite + station toggle#23
Merged
Conversation
Detour accuracy: replace dual Valhalla calls with single call + proportional baseline estimated from the original route duration. Uses a 15% window with through-waypoints pinning highway segments before/after the station. Station toggle: clicking an already-selected station (map or sidebar) now deselects it and clears the leg preview. Selected station gets a blue ring highlight in the sidebar list.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pull request refactors the detour calculation logic in the route-detour API endpoint to use a single Valhalla call with baseline estimation instead of a two-call approach, and introduces a station selection toggle mechanism across map and search components. The endpoint now requires a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flush_interval -1already applied to production Caddy config (not in this PR — server-side config).Test plan
Summary by CodeRabbit