Draft
Conversation
bugaevc
reviewed
Mar 24, 2026
src/Services/Network/RequestV2.vala
Outdated
| } | ||
|
|
||
| public async bool exec (out GLib.InputStream in_stream, out Soup.MessageHeaders response_headers) throws GLib.Error, Oopsie { | ||
| if (this.cancellable != null && !this.cancellable.is_cancelled ()) this.cancellable.cancel (); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (this.cancellable != null && !this.cancellable.is_cancelled ()) this.cancellable.cancel (); | |
| this.cancellable?.cancel (); |
GLib.Cancellable.cancel () already performs the already-cancelled check.
Owner
Author
- async error parsing - remove useless cancelled branch - bool => void return type - handle cancelled properly
Owner
Author
|
Thanks for the review! Maybe the API should change again and return the inputstream instead of outing it, now that we don't need to return bool |
Collaborator
|
Yeah that makes sense too. |
bugaevc
reviewed
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sup: #1481
fix: #1480