System Admin / Authentication: LDAP Implementation#1691
Draft
powertashton wants to merge 2 commits intoGibbonEdu:v25.0.00from
Draft
System Admin / Authentication: LDAP Implementation#1691powertashton wants to merge 2 commits intoGibbonEdu:v25.0.00from
powertashton wants to merge 2 commits intoGibbonEdu:v25.0.00from
Conversation
Almost complete LDAP implementation using the Aura Auth LDAP
Member
|
This looks very cool! I'll leave it to Sandra to review. |
Member
|
Hi @powertashton Looks like this PR is shaping up nicely! It appears to be a nice clean implementation so-far, give a shout with any questions as you get the PR ready to review & merge 😄 |
Member
|
Hi @powertashton I've added the "in development" label to this PR for now, since it's in draft mode. Feel free to give a shout if you'd like anything reviewed or tested at this point. I think there will definitely be some schools very happy to see this in the core 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an almost complete LDAP implementation using the Aura Auth library that is already used in Gibbon for other forms of authentication.
Still TODO for this PR:
TODO in future PRs:
Initially made this for use at my old workplace to facilitate easy login to Gibbon, as users were used to only ever needing to use their AD credentials that were linked to most other systems used in the school. Still some configuration that needs working on before merging but wanted to make sure this project doesn't just get lost in my piles of files.