Replace Travis CI with GitHub Actions#952
Conversation
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
Co-authored-by: amitaibu <125707+amitaibu@users.noreply.github.com>
- Replace manual curl GitHub API calls with gh CLI commands in DeploymentTrait - gh pr view for fetching PR data - gh repo view for checking repo visibility - gh issue comment for posting comments - Remove unused docker_mirror_url parameter from BootstrapTrait - Remove unused $github_token variable (gh CLI uses GITHUB_TOKEN env var automatically) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Create unified ci.yml workflow consolidating all CI/CD jobs. Rename deploy-key to pantheon-key for clarity. Fix TRAVIS_TAG references in check_live_deploy.sh. Changes: - Create .github/workflows/ci.yml with unified CI/CD pipeline - Update ci-scripts/check_live_deploy.sh: TRAVIS_TAG → GITHUB_REF_NAME - Update ci-scripts/prepare_deploy.sh: deploy-key → pantheon-key - Update robo-components/DeploymentTrait.php: excludes and deployment comment - Update .gitignore: add pantheon-key references Based on jep-cjil PRs #10 and #11. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This reverts commit 75942bd.
…s-ci-with-gh-actions
|
Ready for review? |
…s-ci-with-gh-actions
|
@copilot At .github/workflows/deploy.yml, make |
Co-authored-by: AronNovak <114076+AronNovak@users.noreply.github.com>
Done in 2f5dd5a. Changed |
robo-components/DeploymentTrait.php
Outdated
| // Retrieve the issue number from the PR description via GitHub CLI. | ||
| $pr_number = $pr_matches[1][0]; | ||
| $pr = $this->taskExec("curl -H \"Authorization: token $github_token\" https://api.github.com/repos/" . self::$githubProject . "/pulls/$pr_number") | ||
| $pr_body = $this->taskExec("gh pr view $pr_number --json body --jq .body") |
There was a problem hiding this comment.
@copilot deployNotify - here please revert the changes, we cannot assume that gh CLI is installed
There was a problem hiding this comment.
Reverted in 290fff7. The deployNotify method now uses curl with GitHub API instead of gh CLI. Changes:
- PR retrieval:
gh pr view→curlto GitHub API/pulls/{pr_number} - Repo privacy check:
gh repo view→curlto GitHub API/repos/{owner}/{repo} - Comment posting:
gh issue comment→curl -X POSTto GitHub API/issues/{issue_number}/comments
There was a problem hiding this comment.
@amitaibu Inside GH Actions pipeline + DDEV, when we do deployment notifications, gh CLI is not present.
For sure using curl is more error-prone. Installing gh CLI is slow and it means one more external dependency to the process. That's why I decided to revert this, it is out of scope here, GitHub notifier rework is not part of the GH Actions migration.
Co-authored-by: AronNovak <114076+AronNovak@users.noreply.github.com>
|
Shouldn't |
This is just a dummy token that we use to persuade Rollbar module to try to communicate with the API for the sake of memory pressure test. |
|
@amitaibu This is ready for review, then we can do a follow-up PR to take care of the process of bootstrapping a new project from zero. |
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.