-
Notifications
You must be signed in to change notification settings - Fork 55
Support phpactor #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support phpactor #980
Conversation
AronNovak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there's phpstan integration. Did you use it? Can it auto-correct the findings using phpactor?
| "extra": { | ||
| "autoload-drupal": { | ||
| "modules": [ | ||
| "app/modules/contrib/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there are two ways to use it. This is option 2). It seems to be more invasive. But might be fine, just asking why option 1) isn't chosen here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AronNovak Honestly I haven't tried option 1 to see if it works fine with ddev. Based on the frequency of installing new modules it seems a faster option to go with a static approach, if the db is broken this should still work.
@AronNovak Yes, I installed it but it was reporting more errors than we see in the regular phpstan config so I disable it. I still need to figure out how to use the default config instead of the one that provides phpactor. Enabling "language_server_phpstan.enabled": true,
|
…tor.json.example. Add docs
|
@AronNovak I think is better to have a template instead so devs can configure phpactor according to their needs. |

https://phpactor.readthedocs.io/en/master/integrations/drupal8.html
Peek.2026-01-29.16-19.mp4