Skip to content

Conversation

@mariano-dagostino
Copy link
Collaborator

@mariano-dagostino mariano-dagostino commented Jan 29, 2026

Copy link
Member

@AronNovak AronNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there's phpstan integration. Did you use it? Can it auto-correct the findings using phpactor?

"extra": {
"autoload-drupal": {
"modules": [
"app/modules/contrib/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://phpactor.readthedocs.io/en/master/integrations/drupal8.html#option-1-bootstrap-drupal-on-the-fly-to-generate-the-autoloader

I see that there are two ways to use it. This is option 2). It seems to be more invasive. But might be fine, just asking why option 1) isn't chosen here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AronNovak Honestly I haven't tried option 1 to see if it works fine with ddev. Based on the frequency of installing new modules it seems a faster option to go with a static approach, if the db is broken this should still work.

@mariano-dagostino
Copy link
Collaborator Author

mariano-dagostino commented Feb 2, 2026

I see that there's phpstan integration. Did you use it? Can it auto-correct the findings using phpactor?

@AronNovak Yes, I installed it but it was reporting more errors than we see in the regular phpstan config so I disable it. I still need to figure out how to use the default config instead of the one that provides phpactor.

Enabling "language_server_phpstan.enabled": true,in.phactor.json` shows phpstan errors.

Screenshot_2026-02-02_16-05-38

@mariano-dagostino
Copy link
Collaborator Author

@AronNovak I think is better to have a template instead so devs can configure phpactor according to their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants