-
Notifications
You must be signed in to change notification settings - Fork 0
Major remove volume mappings from registry services #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Major remove volume mappings from registry services #26
Conversation
Removed volume mappings for all registry services. We don't need it anymore given how we provision we just do it via cloud-init and it all comes online. The node is intended to just get nuked and not be a long lived store
PR Checklist (required):
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes volume mappings from all registry services in the Docker Compose configuration. This change affects data persistence for registry proxy services by removing the shared ./data:/var/lib/registry volume mount from all registry services.
- Removed volume mappings from all registry services (registry-docker, registry-quay, registry-ghcr, etc.)
- Eliminated persistent storage configuration for registry data
- Simplified service definitions by removing volume configuration sections
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| registry-docker: | ||
| image: registry:3@sha256:3725021071ec9383eb3d87ddbdff9ed602439b3f7c958c9c2fb941049ea6531d | ||
| volumes: | ||
| - ./data:/var/lib/registry | ||
| ports: | ||
| - "5000:5000" | ||
| environment: | ||
| REGISTRY_PROXY_REMOTEURL: https://registry-1.docker.io | ||
| restart: always |
Copilot
AI
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing volume mappings means registry data will not persist across container restarts. This could lead to repeated downloads of the same images and loss of cached registry data, potentially impacting performance and bandwidth usage. Consider whether ephemeral storage is intentional for these proxy registries.
PR Type
Other
Description
Remove volume mappings from all registry services
Eliminate persistent data storage for registry proxies
Transition to ephemeral registry configuration
Diagram Walkthrough
File Walkthrough
docker-compose.yml
Remove volume mappings from registry servicesdocker-compose.yml
./data:/var/lib/registryvolume mappings from all 9 registryservices