Rework interactables #692
Draft
Rework interactables #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to keep track of an 'original' transform before 'driven' changes are made. For example 'slider_position' or 'hinge_position' being changed due to handle movement.
- Remove shadowed variable names
- Removed shadowed variable names
squidt
force-pushed
the
rework-interactables
branch
from
68fcf8f to
4c7e466
Compare
- Calculate derived variables instead of setting - Remove unused variable - Fix the 'get_final_axis()' to just be the local 'hinge_axis' direction set by user - Remove 'get_final_axis()' - Remove extra check for change before setting 'hinge_position'
Contributor
Author
|
Last commit also added 'hinge_wrapping' bool for wrapping between min and max limits (infinitely spinning wheel). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactables use an empty Node3D as a parent and 'origin' node to set up both handles and interactable_handle_driven scenes. This PR will attempt to make the scenes stand alone and more intuitive. Sliders can be orientated in the editor and slide along their rotated axis. Hinges can do the same and offer 'hinge_axis' as a variable to allow the user to specify an axis to rotate around.
These are breaking changes and a work in progress. Joysticks must be incorporated and handles tested. I'll adjust the interactable_demo_scene to feature the final changes.