-
Notifications
You must be signed in to change notification settings - Fork 40
feat(feature): display vendor positions on feature pages and overview #1975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DanielRyanSmith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with some optional suggestions
This commit introduces the display of vendor standards positions on both the feature detail page and the main feature overview table. Key changes: - Frontend: - A new VendorPosition class and VendorPositions factory are introduced for type-safe parsing of the vendor position data from the API. - The feature detail page now renders a 'Vendor positions' section. - The main feature overview table now displays vendor position tags inline with the feature name. - Fake Data: The fake data generator is updated to produce vendor position data. - Testing: New unit tests for the VendorPosition class and updated Playwright snapshots are included.
The fake data generation for vendor positions was non-deterministic due to iterating over a map without sorting the keys. This caused inconsistent data between Playwright runs, resulting in screenshot diffs. This commit fixes the issue by sorting the keys in the `getAllVendorPositions` function, ensuring that the fake data is generated in a deterministic order.
c1bd5e9 to
0f37ccf
Compare
|
For this, I actually added code to generate the enums from the jsonschema: webstatus.dev/jsonschema/web-platform-dx_web-features-mappings/combined-schema.gen.json Lines 188 to 212 in 932d7cc
That way I can keep it aligned and not manually maintain the list of possible vendors. GitHub CI is having unrelated problems with devcontainer. But this all works locally |
This commit introduces the display of vendor standards positions on both the feature detail page and the main feature overview table.
Key changes: