chore(implementation): use Jetty-12.1 core without servlets #333

lachlan-roberts · 2025-09-26T03:12:29Z

This is based on the work from #235.

Port the invoker to upgrade to Eclipse Jetty-12 version 12. Specifically using the new core APIs of Eclipse Jetty-12 that allow the overhead of a Servlet container to be avoided.

BREAKING CHANGE: use Java 17 or above, as required by Eclipse Jetty-12.

Replaces

Port the invoker to upgrade to Eclipse Jetty-12 version 12. Specifically using the new core APIs of Eclipse Jetty-12 that allow the overhead of a Servlet container to be avoided. BREAKING CHANGE: use Java 17 or above, as required by Eclipse Jetty-12. Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>

ludoch · 2025-10-03T17:59:16Z

Thanks!
We need to remove jdk11 constraints in builds. I guess only a Googler can understand and change the kokoro files to jdk17

Also all references with maven.compiler.source>11</maven.compiler.source> need to change to 17

ludoch · 2025-10-03T18:00:13Z

For ex, remove https://github.com/GoogleCloudPlatform/functions-framework-java/blob/cd6caeda00262b2558815ae22cfc726c0638122a/.github/workflows/buildpack-integration-test.yml#L17https://github.com/GoogleCloudPlatform/functions-framework-java/blob/cd6caeda00262b2558815ae22cfc726c0638122a/.github/workflows/buildpack-integration-test.yml#L17

Maybe add java21 or 25

ludoch · 2025-10-03T18:04:02Z

@akerekes please help on google internal kokoro workflows.
The entire new code now has to only work with java17,21 and 25, so drop 11 and add new configs.

akerekes · 2025-10-03T21:01:41Z

Hi @lachlan-roberts , thank you for the PR! I'll work on the Google internal side. One note on the timeline is that Cloud Function deprecates java11 at the end of the month: https://cloud.google.com/functions/docs/runtime-support#java so my preference is to have this PR ready to merge, but wait until the end of the month with the merge, then do it in early November and release a new version of the FF-java library.

akerekes

Thank you @lachlan-roberts for the PR! I did the first round of review.

Please rebase the PR to HEAD one more time, I'm not planning to merge any other PRs until this one is done to avoid further rebasing and merge conflicts.

invoker/core/src/main/java/com/google/cloud/functions/invoker/BackgroundFunctionExecutor.java

invoker/core/src/main/java/com/google/cloud/functions/invoker/http/HttpRequestImpl.java

invoker/core/src/test/java/com/google/cloud/functions/invoker/http/HttpTest.java

invoker/core/pom.xml

Port the invoker to upgrade to Eclipse Jetty-12 version 12. Specifically using the new core APIs of Eclipse Jetty-12 that allow the overhead of a Servlet container to be avoided. BREAKING CHANGE: use Java 17 or above, as required by Eclipse Jetty-12. Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>

maemayve · 2025-10-29T17:10:51Z

invoker/core/src/main/java/com/google/cloud/functions/invoker/BackgroundFunctionExecutor.java

    } finally {
      executionIdUtil.removeExecutionId();
    }
+    return true;


Can you add a comment here or at the top of the method explaining the return value? It seems confusing to me at face value

This is specified in the javadoc of handle

Returns:
True if and only if the request will be handled, a response generated and the callback eventually called. This may occur within the scope of the call to this method, or asynchronously some time later. If false is returned, then this method must not generate a response, nor complete the callback.

In this case we are always handling the request so we should always return true.

maemayve · 2025-10-29T17:11:45Z

invoker/core/src/main/java/com/google/cloud/functions/invoker/BackgroundFunctionExecutor.java

    FunctionExecutor<CloudEventT> executor = (FunctionExecutor<CloudEventT>) functionExecutor;
-    byte[] body = req.getInputStream().readAllBytes();
+
+    byte[] body = Content.Source.asByteArrayAsync(req, -1).get();


Can you explain this array manipulation in a comment? why the '-1'?

This asByteArrayAsync method is now deprecated without replacement, I have opened jetty/jetty.project#13939 for an replacement method as Content.Source.asInputStream(req).readAllBytes() could be much less efficient.

But this is simply reading the entire content of the request into a byte[]. The second argument was the length of the content with -1 meaning read until EOF.

maemayve · 2025-10-29T17:26:16Z

invoker/core/src/main/java/com/google/cloud/functions/invoker/http/TimeoutHandler.java

+        new TimerTask() {
+          @Override
+          public void run() {
+            // TODO: there is a race between the handler writing response and timeout firing.


Can you add the action item to this TODO? what needs to be done to address this race condition?

The race condition is intrinsic to this approach, and was also present using the original TimeoutFilter. And there were also various other problems with the original TimeoutFilter.

I have pushed another commit to improve this.

Before the timeout was per call to doFilter, it was not measuring the total time for the handling of the request/response to complete.

It used to create a new Timer for every call to doFilter() (possibly multiple times per request), now it reuses the Scheduler of the server and only once per request.

akerekes · 2025-10-29T20:29:01Z

@lachlan-roberts Thank you for the follow-up. Can you reformat the code to make the linter check pass?

The PR looks good to me, I'm waiting on @maemayve 's comments to be resolved and happy to approve it then.

Port the invoker to upgrade to Eclipse Jetty-12 version 12. Specifically using the new core APIs of Eclipse Jetty-12 that allow the overhead of a Servlet container to be avoided. BREAKING CHANGE: use Java 17 or above, as required by Eclipse Jetty-12. Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>

lachlan-roberts added 2 commits September 25, 2025 18:44

lachlan-roberts changed the title ~~use Jetty-12.1 core without servlets~~ chore(implementation): use Jetty-12 core without servlets Sep 30, 2025

lachlan-roberts changed the title ~~chore(implementation): use Jetty-12 core without servlets~~ chore(implementation): use Jetty-12.1 core without servlets Sep 30, 2025

ludoch requested a review from akerekes October 3, 2025 18:02

ludoch self-requested a review October 3, 2025 18:04

akerekes reviewed Oct 23, 2025

View reviewed changes

ludoch requested changes Oct 27, 2025

View reviewed changes

invoker/core/pom.xml Outdated Show resolved Hide resolved

lachlan-roberts added 2 commits October 29, 2025 21:32

Merge remote-tracking branch 'origin/main' into jetty-12.1-no-servlets

cff88d1

lachlan-roberts requested review from akerekes and ludoch October 29, 2025 11:35

maemayve requested changes Oct 29, 2025

View reviewed changes

chore(implementation): use Jetty-12.1 core without servlets #333

Are you sure you want to change the base?

chore(implementation): use Jetty-12.1 core without servlets #333

Uh oh!

Conversation

lachlan-roberts commented Sep 26, 2025

Uh oh!

ludoch commented Oct 3, 2025

Uh oh!

ludoch commented Oct 3, 2025

Uh oh!

ludoch commented Oct 3, 2025

Uh oh!

akerekes commented Oct 3, 2025

Uh oh!

akerekes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maemayve Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

lachlan-roberts Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

maemayve Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

lachlan-roberts Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

maemayve Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

lachlan-roberts Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

akerekes commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants