Skip to content

Add support for ReservationGroup to bigqueryreservation#16765

Open
jielin-bq wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jielin-bq:main
Open

Add support for ReservationGroup to bigqueryreservation#16765
jielin-bq wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jielin-bq:main

Conversation

@jielin-bq
Copy link

@jielin-bq jielin-bq commented Mar 19, 2026

This is to add support for ReservationGroup to bigqueryreservation by adding a reservation_group as a new resource as well as adding reservation_group as a new property to the existing resource reservation. See b/452350812 for more details.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigqueryreservation: added `reservation_group` field to `reservation` resource
`google_bigqueryreservation_reservation_group`

…roperty to resource Reservation in bigqueryreservation
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 728 files changed, 2393 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 806 files changed, 2549 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 105 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5494
Passed tests: 5006
Skipped tests: 483
Affected tests: 5

Click here to see the affected service packages
  • certificatemanager
  • cloudbuild
  • edgenetwork
  • spanner
  • storagebatchoperations
  • deploymentmanager
  • firebasehosting
  • storagetransfer
  • bigqueryconnection
  • bigtable
  • binaryauthorization
  • containerattached
  • redis
  • sourcerepo
  • transcoder
  • cloudrun
  • compute
  • containeranalysis
  • firebaseailogic
  • pubsublite
  • documentai
  • iam2
  • iam3
  • oracledatabase
  • sql
  • storageinsights
  • dataplex
  • cloudrunv2
  • cloudsecuritycompliance
  • databasemigrationservice
  • gkeonprem
  • storage
  • workbench
  • apigateway
  • cloudidentity
  • dialogflow
  • eventarc
  • iambeta
  • saasruntime
  • secretmanagerregional
  • integrationconnectors
  • beyondcorp
  • cloudids
  • colab
  • dns
  • filestore
  • notebooks
  • securitycentermanagement
  • composer
  • edgecontainer
  • firebaseapphosting
  • workstations
  • cloudasset
  • cloudfunctions2
  • cloudquotas
  • gkehub2
  • kms
  • logging
  • memcache
  • ces
  • cloudscheduler
  • networkconnectivityv1
  • backupdr
  • clouddomains
  • hypercomputecluster
  • tags
  • orgpolicy
  • servicedirectory
  • storagecontrol
  • accessapproval
  • datapipeline
  • developerconnect
  • observability
  • osconfigv2
  • billing
  • networkmanagement
  • oslogin
  • parametermanager
  • gkebackup
  • secretmanager
  • serviceusage
  • biglakeiceberg
  • documentaiwarehouse
  • firebase
  • integrations
  • looker
  • monitoring
  • pubsub
  • cloudbuildv2
  • tpuv2
  • contactcenterinsights
  • firebasedataconnect
  • iap
  • vectorsearch
  • gkehub
  • migrationcenter
  • memorystore
  • apihub
  • bigquerydatapolicyv2
  • bigqueryreservation
  • cloudtasks
  • datacatalog
  • essentialcontacts
  • firebaseappcheck
  • apigee
  • artifactregistry
  • bigquery
  • bigquerydatapolicy
  • dataproc
  • modelarmor
  • privateca
  • securityscanner
  • blockchainnodeengine
  • datalossprevention
  • dataprocmetastore
  • firestore
  • mlengine
  • osconfig
  • privilegedaccessmanager
  • securesourcemanager
  • modelarmorglobal
  • accesscontextmanager
  • activedirectory
  • discoveryengine
  • healthcare
  • securitycenter
  • servicenetworking
  • vpcaccess
  • networkconnectivity
  • apphub
  • dataprocgdc
  • datastream
  • firebaseextensions
  • parametermanagerregional
  • resourcemanager
  • biglake
  • dialogflowcx
  • firebasedatabase
  • managedkafka
  • vertexai
  • appengine
  • bigqueryanalyticshub
  • chronicle
  • clouddeploy
  • identityplatform
  • networkservices
  • parallelstore
  • securityposture
  • bigquerydatatransfer
  • corebilling
  • datafusion
  • firebasestorage
  • netapp
  • iamworkforcepool
  • resourcemanager3
  • vmwareengine
  • alloydb
  • dataform
  • gemini
  • networksecurity
  • securitycenterv2
  • siteverification
  • lustre
  • workflows

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryReservationGroup_basic
  • TestAccBigqueryReservationReservationGroup_bigqueryReservationGroupBasicExample
  • TestAccBigqueryReservation_reservationGroup_update
  • TestAccDataformConfig_update
  • TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

@jielin-bq jielin-bq marked this pull request as ready for review March 19, 2026 16:52
@github-actions github-actions bot requested a review from trodge March 19, 2026 16:52
@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants