Use Terraform to manage cloud-build triggers#1472
Draft
linsword13 wants to merge 10 commits intoGoogleCloudPlatform:developfrom
Draft
Use Terraform to manage cloud-build triggers#1472linsword13 wants to merge 10 commits intoGoogleCloudPlatform:developfrom
linsword13 wants to merge 10 commits intoGoogleCloudPlatform:developfrom
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
linsword13
force-pushed
the
cloud-build-triggers
branch
from
a5b0c72 to
990b2ce
Compare
linsword13
changed the title
linsword13
changed the title
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Terraform configurations to manage Google Cloud Build triggers for the Ramble repository, covering image builds, unit tests, performance tests, and style checks. The review feedback highlights several maintainability and security improvements: transitioning from end-of-life Python versions (3.7 and 3.8) to supported ones, replacing hardcoded version strings in trigger names and substitutions with dynamic references to the local image matrix, and removing the --auto-approve flag from the deployment documentation to encourage safer manual reviews.
share/ramble/cloud-build/terraform/triggers/pr_software_conflicts.tf
Outdated
Show resolved
Hide resolved
share/ramble/cloud-build/terraform/triggers/pr_software_conflicts.tf
Outdated
Show resolved
Hide resolved
linsword13
force-pushed
the
cloud-build-triggers
branch
from
be73c52 to
f1ce6ce
Compare
But don't set it for push-based triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use terraform to describe the triggers. This makes it easy to update/add these triggers.
Besides porting the existing active triggers into Terraform configuration, also add in triggers for building new images upon code merging into develop.