make get_newest_experiment_file more resilient to deletes#1476
Open
rfbgo wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Open
make get_newest_experiment_file more resilient to deletes#1476rfbgo wants to merge 1 commit intoGoogleCloudPlatform:developfrom
rfbgo wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the get_newest_experiment_file function to use a manual stack-based walk with os.scandir instead of pathlib.rglob. Feedback suggests broadening exception handling from FileNotFoundError to OSError to account for NotADirectoryError and PermissionError, which prevents potential regressions and improves robustness against inaccessible files or directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this function got a list of files, and then got the times. This left us open to a TOCTOU race and would lead to a crash. This version should be faster and more resilient (but it's hard to test diligently..)