added release state display to info app

[DirkBaumeister]

I tried to add a release state to the release notes tab in the info app.

It should look like this:

It fetches the current release state by using the android.os.Build.BOARD constant for stable, beta and alpha by constructing the url https://releases.grapheneos.org/$board-$releasePhase

Feedback is very much welcomed as these are my first steps in kotlin 😄

[matchboxbananasynergy]

So this checks for which model you have and fetched the values for your own device? What channel a release is in can differ per device.

[DirkBaumeister]

Yes, that's right.
As long as android.os.Build.BOARD gives the correct device name (husky for Pixel 8 Pro) for example it checks for the specific releases for this model the app is running on.
In the case of the Pixel 8 Pro it fetches for example the following urls:

https://releases.grapheneos.org/husky-stable
https://releases.grapheneos.org/husky-beta
https://releases.grapheneos.org/husky-alpha

and parses the release number from each request and shows it in the according box.

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name 😄

[matchboxbananasynergy]

Thanks. We'll get around to looking at this soon.

[muhomorr]

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name

It does currently, but is not guaranteed to be set to the required value for future devices. android.os.Build.DEVICE is the right variable to check for this use-case AFAIK.

[DirkBaumeister]

Would be great if someone could verify that android.os.Build.BOARD really gives the right model name

It does currently, but is not guaranteed to be set to the required value for future devices. android.os.Build.DEVICE is the right variable to check for this use-case AFAIK.

Thank you 🙂 I have changed it to this variable

[thestinger]

Needs to be rebased due to various conflicting changes.

[DirkBaumeister]

Made a rebase and should be compatible with the current main again :)

[DirkBaumeister]

Thanks :) I have resolved all your mentioned things in my code. @soupslurpr

[soupslurpr]

Thank you. It needs a few more changes and then it should be ready to be merged.

[DirkBaumeister]

Thanks again for the feedback :) Should be resolved now @soupslurpr

[DirkBaumeister]

Just another edit: I have noticed that I haven't added updateReleaseStates to Lifecycle.Event.ON_START and to the PullToRefreshBox.
It's now implemented like updateChangelog is. Can you please check if it is done right this way? @soupslurpr

[soupslurpr]

Thanks for noticing and adding that. It mostly looks good now, there's just one thing I'm unsure of.

[DirkBaumeister]

Thanks for the idea :) I think I also got this working now @soupslurpr

[soupslurpr]

Everything looks good to me now! Thank you for the contribution.

[DirkBaumeister]

Happy to help :) And thanks again for your feedback! :)

[DirkBaumeister]

So, is there any estimation when this probably could get merged? 🙂

[DirkBaumeister]

So, just kindly want to bump this PR up :) Anything I should do before it can be merged?

[thestinger]

We have a lot of very high priorities and many recent PRs we've merged have caused issues resulting in needing to make unplanned emergency releases. It's not really a good time to be merging things we don't consider high priority.

[DirkBaumeister]

Thanks for the feedback :) Totally understandable! I will keep the PR updated from time to time if the main changes and maybe there comes a better time for merging it. Thanks again and also thanks for your awesome work!

[mio-19]

There are some conflicts with main branch

[DirkBaumeister]

There are some conflicts with main branch

Resolved the conflicts 🙂

[thestinger]

It needs to be rebased.

[thestinger]

It still needs to be rebased against the current code and cleaned up.

[DirkBaumeister]

Honestly I am not really familiar with rebasing. Would you mind telling me if I got it right now? Or how to do it right?

[thestinger]

No, this is definitely not right. It needs to be substantially cleaned up before it can be reviewed.

[DirkBaumeister]

Okay, but unfortunately I don't really know what you mean by cleaning up. If you can give me a hint where I can start than I'm definitely trying to resolve the problems.

Thank you for your time

[dot166]

Okay, but unfortunately I don't really know what you mean by cleaning up. If you can give me a hint where I can start than I'm definitely trying to resolve the problems.

Thank you for your time

I think he means that there is duplicate commits, and it is cluttering the PR, just squash all the commits into one commit and should be problem solved, I think

[DirkBaumeister]

Okay, but unfortunately I don't really know what you mean by cleaning up. If you can give me a hint where I can start than I'm definitely trying to resolve the problems.
Thank you for your time

I think he means that there is duplicate commits, and it is cluttering the PR, just squash all the commits into one commit and should be problem solved, I think

Okay, thanks for the reply :) I squashed my commits now into one, hope that helps

[mio-19]

This feature works very well on my device! It is helpful